Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread van der Linden, Frank
Resubmitted. The various release/deref requirements in that path make a straight "goto csum_error" impossible without duplicating some lines, but this is 2nd best. Frank On 6/11/18, 4:43 PM, "van der Linden, Frank" wrote: Yeah, true, it's missing INERRS in this case. I'll fix it up a bit

Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-11 Thread van der Linden, Frank
Yeah, true, it's missing INERRS in this case. I'll fix it up a bit. Frank On 6/11/18, 4:38 PM, "Eric Dumazet" wrote: On 06/11/2018 04:25 PM, van der Linden, Frank wrote: > A few comments on this one: > > - obviously this is fairly serious, as it can let corrupted dat

Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-11 Thread Eric Dumazet
On 06/11/2018 04:25 PM, van der Linden, Frank wrote: > A few comments on this one: > > - obviously this is fairly serious, as it can let corrupted data all the way > up to the application Sure, although anyone relying on CRC checksum for ensuring TCP data integrity has big troubles ;) I woul

Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-11 Thread van der Linden, Frank
A few comments on this one: - obviously this is fairly serious, as it can let corrupted data all the way up to the application - I am not nuts about the patch itself, the code feels a bit cluttered, but it's the least invasive way I could think of. Probably some refactoring is needed at some p

[PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-11 Thread Frank van der Linden
commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table") introduced an optimization for the handling of child sockets created for a new TCP connection. But this optimization passes any data associated with the last ACK of the connection handshake up the stack without verifying