Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-02 Thread kbuild test robot
Hi Gustavo, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-02 Thread kbuild test robot
Hi Gustavo, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi Andrew, Quoting Andrew Lunn : On Wed, Jan 31, 2018 at 07:07:49PM -0600, Gustavo A. R. Silva wrote: Hi Alan, Quoting Alan Cox : >On Wed, 31 Jan 2018 18:24:07 -0600 >"Gustavo A. R. Silva" wrote: > >>Cast to s64 some variables and a macro in order to give the >>compiler complete informatio

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi David, Quoting David Miller : From: "Gustavo A. R. Silva" Date: Wed, 31 Jan 2018 18:24:07 -0600 Cast to s64 some variables and a macro in order to give the compiler complete information about the proper arithmetic to use. Notice that these elements are used in contexts that expect express

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi David, Quoting David Laight : > The question you need to ask is 'can it overflow 32bit maths', otherwise > you are potentially making the system do extra work for no reason. > Yeah, I get your point and it seems that in this particular case there is no risk of a 32bit overflow, but in gener

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 31 Jan 2018 18:24:07 -0600 > Cast to s64 some variables and a macro in order to give the > compiler complete information about the proper arithmetic to > use. Notice that these elements are used in contexts that > expect expressions of type s64 (64 bits, sig

RE: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread David Laight
> > The question you need to ask is 'can it overflow 32bit maths', otherwise > > you are potentially making the system do extra work for no reason. > > > > Yeah, I get your point and it seems that in this particular case there > is no risk of a 32bit overflow, but in general and IMHO as the code >

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-01-31 Thread Andrew Lunn
On Wed, Jan 31, 2018 at 07:07:49PM -0600, Gustavo A. R. Silva wrote: > > Hi Alan, > > Quoting Alan Cox : > > >On Wed, 31 Jan 2018 18:24:07 -0600 > >"Gustavo A. R. Silva" wrote: > > > >>Cast to s64 some variables and a macro in order to give the > >>compiler complete information about the proper

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-01-31 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Cox : On Wed, 31 Jan 2018 18:24:07 -0600 "Gustavo A. R. Silva" wrote: Cast to s64 some variables and a macro in order to give the compiler complete information about the proper arithmetic to use. Notice that these elements are used in contexts that expect expressions o

[PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-01-31 Thread Gustavo A. R. Silva
Cast to s64 some variables and a macro in order to give the compiler complete information about the proper arithmetic to use. Notice that these elements are used in contexts that expect expressions of type s64 (64 bits, signed). Currently such expression are being evaluated using 32-bit arithmetic

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-01-31 Thread Alan Cox
On Wed, 31 Jan 2018 18:24:07 -0600 "Gustavo A. R. Silva" wrote: > Cast to s64 some variables and a macro in order to give the > compiler complete information about the proper arithmetic to > use. Notice that these elements are used in contexts that > expect expressions of type s64 (64 bits, signe