Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-22 Thread Vincent Bernat
❦ 20 août 2015 14:07 -0700, David Miller da...@davemloft.net : I also don't know what is the best way to handle this. veth advertises its peer via IFLA_LINK since 4.1, so it's too late to change it for this release. Apparently we need to pick our poison. Either way, we break something.

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-20 Thread Jiri Benc
On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: Probably better to introduce veth netlink attribute then, something like IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID. I'd prefer IFLA_PEER. More generic attribute will be helpful should we introduce an interface similar to veth in the

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-20 Thread Nicolas Dichtel
Le 20/08/2015 13:53, Jiri Benc a écrit : On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: Probably better to introduce veth netlink attribute then, something like IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID. I'd prefer IFLA_PEER. More generic attribute will be helpful should we

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-20 Thread David Miller
From: Nicolas Dichtel nicolas.dich...@6wind.com Date: Thu, 20 Aug 2015 16:31:11 +0200 Le 20/08/2015 13:53, Jiri Benc a écrit : On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: Probably better to introduce veth netlink attribute then, something like IFLA_VETH_PEER and keeps

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Jiri Benc
On Wed, 19 Aug 2015 14:13:00 +0200, Vincent Bernat wrote: That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices topology. iflink has always been the index of a

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Vincent Bernat
❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices topology. iflink has always been the index of a

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Nicolas Dichtel
Le 19/08/2015 14:48, Vincent Bernat a écrit : ❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Jiri Benc
On Wed, 19 Aug 2015 08:44:08 +0200, Vincent Bernat wrote: While the documentation doesn't say exactly what kind of relationship iflink should represent, until a45253, only lower devices were advertised this way. While veth cannot have a lower device, using iflink to advertise the peer may

[PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Vincent Bernat
While the documentation doesn't say exactly what kind of relationship iflink should represent, until a45253, only lower devices were advertised this way. While veth cannot have a lower device, using iflink to advertise the peer may create infinite loops in programs using iflink to discover device