Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures

2017-01-10 Thread Michael S. Tsirkin
On Tue, Jan 10, 2017 at 06:11:25PM +0530, Bhumika Goyal wrote: > On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: > >> Declare target_core_fabric_ops strucrues as const as they are only > >> passed as

Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures

2017-01-10 Thread Bhumika Goyal
On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: >> Declare target_core_fabric_ops strucrues as const as they are only >> passed as an argument to the functions target_register_template and >>

Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: > Declare target_core_fabric_ops strucrues as const as they are only > passed as an argument to the functions target_register_template and > target_unregister_template. The arguments are of type const struct > target_core_fabric_ops

Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures

2017-01-09 Thread Jason Wang
On 2017年01月09日 23:21, Bhumika Goyal wrote: Declare target_core_fabric_ops strucrues as const as they are only passed as an argument to the functions target_register_template and target_unregister_template. The arguments are of type const struct target_core_fabric_ops *, so

[PATCH] vhost: scsi: constify target_core_fabric_ops structures

2017-01-09 Thread Bhumika Goyal
Declare target_core_fabric_ops strucrues as const as they are only passed as an argument to the functions target_register_template and target_unregister_template. The arguments are of type const struct target_core_fabric_ops *, so target_core_fabric_ops structures having this property can be