Re: [PATCH]dgrs - Fixes Warnings when CONFIG_ISA and CONFIG_PCI are not enabled

2005-11-05 Thread Andrew Morton
Richard Knutsson <[EMAIL PROTECTED]> wrote: > > Richard Knutsson wrote: > > > Andrew Morton wrote: > > > >> Richard Knutsson <[EMAIL PROTECTED]> wrote: > >> > >> > */ > > >>> > >>> > #ifdef CONFIG_EISA > >>> >-eisacount = eisa_driver_register(&dgrs_eisa_driver); > >>> >-

Re: [PATCH]dgrs - Fixes Warnings when CONFIG_ISA and CONFIG_PCI are not enabled

2005-11-05 Thread Andrew Morton
Richard Knutsson <[EMAIL PROTECTED]> wrote: > > BTW, can anyone ack or is that up to the maintainers? It's useful info - it shows that someone else took the time to revie the code. > BTW #2, why not remove #ifdef CONFIG_PCI on dgrs_cleanup_module() at the > same time? Or maybe that should be

Re: [PATCH]dgrs - Fixes Warnings when CONFIG_ISA and CONFIG_PCI are not enabled

2005-11-05 Thread Richard Knutsson
Richard Knutsson wrote: Andrew Morton wrote: Richard Knutsson <[EMAIL PROTECTED]> wrote: */ > #ifdef CONFIG_EISA >-eisacount = eisa_driver_register(&dgrs_eisa_driver); >-if (eisacount < 0) >-return eisacount; >-#endif >-#ifdef CONFIG_PCI >-pcicount = pci_reg

Re: [PATCH]dgrs - Fixes Warnings when CONFIG_ISA and CONFIG_PCI are not enabled

2005-11-05 Thread Richard Knutsson
Andrew Morton wrote: Richard Knutsson <[EMAIL PROTECTED]> wrote: */ > #ifdef CONFIG_EISA >- eisacount = eisa_driver_register(&dgrs_eisa_driver); >- if (eisacount < 0) >- return eisacount; >-#endif >-#ifdef CONFIG_PCI >- pcicount = pci_register_driver(&dgrs_pc