Re: [irda-users] [PATCH]race between open and disconnect in irda-usb

2007-10-12 Thread Samuel Ortiz
Hi Oliver, On Fri, Oct 12, 2007 at 10:53:55AM +0200, Oliver Neukum wrote: > Hi, > > it seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kill all URBs, if it is called > while an interface is opened. Makes sense, yes. I will push it upstream

[PATCH]race between open and disconnect in irda-usb

2007-10-12 Thread Oliver Neukum
Hi, it seems to me that irda_usb_net_open() must set self->netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Regards Oliver --- a/drivers/net/irda/irda-us

Re: [PATCH]race between open and disconnect in irda-usb

2007-10-11 Thread Jean Tourrilhes
On Thu, Oct 11, 2007 at 05:45:28PM +0200, Oliver Neukum wrote: > Hi, > Hi, You need to cc Samuel Ortiz and the IrDA mailing list if you want any meaningful response. > it seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kil

[PATCH]race between open and disconnect in irda-usb

2007-10-11 Thread Oliver Neukum
Hi, it seems to me that irda_usb_net_open() must set self->netopen under spinlock or disconnect() may fail to kill all URBs. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Regards Oliver --- a/drivers/net/irda/irda-usb.c 2007-10-11 17:24:35.0 +0200