Re: [PATCH -next 3/4] sched: remove qdisc_rehape_fail

2016-06-08 Thread Eric Dumazet
On Wed, 2016-06-08 at 23:01 +0200, Florian Westphal wrote: > > Would you mind an annotation rather than covering the hole? > > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -71,11 +71,11 @@ struct Qdisc { > struct gnet_stats_basic_cpu __percpu *cpu_bstats; >

Re: [PATCH -next 3/4] sched: remove qdisc_rehape_fail

2016-06-08 Thread Florian Westphal
Eric Dumazet wrote: > On Wed, 2016-06-08 at 17:35 +0200, Florian Westphal wrote: > > After the removal of TCA_CBQ_POLICE in cbq scheduler qdisc->reshape_fail > > is always NULL, i.e. qdisc_rehape_fail is now the same as qdisc_drop. > > > > Signed-off-by: Florian Westphal

Re: [PATCH -next 3/4] sched: remove qdisc_rehape_fail

2016-06-08 Thread Eric Dumazet
On Wed, 2016-06-08 at 17:35 +0200, Florian Westphal wrote: > After the removal of TCA_CBQ_POLICE in cbq scheduler qdisc->reshape_fail > is always NULL, i.e. qdisc_rehape_fail is now the same as qdisc_drop. > > Signed-off-by: Florian Westphal > --- > include/net/sch_generic.h |

[PATCH -next 3/4] sched: remove qdisc_rehape_fail

2016-06-08 Thread Florian Westphal
After the removal of TCA_CBQ_POLICE in cbq scheduler qdisc->reshape_fail is always NULL, i.e. qdisc_rehape_fail is now the same as qdisc_drop. Signed-off-by: Florian Westphal --- include/net/sch_generic.h | 19 --- net/sched/sch_fifo.c | 4 ++--