Re: [PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-12 Thread Charles (Chas) Williams
On Sat, 2015-10-10 at 21:47 +0200, Tillmann Heidsieck wrote: > this series fixes two of them. The if(); warning would require > restructuring the code to a larger extend. Beyond this there remains a > whooping number of > 2k checkpatch.pl warnings and errors each. Those > can be grouped into ...

[PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-10 Thread Tillmann Heidsieck
OK here it goes ... There are three non-indention specific smatch warnings in atm/iphase.c drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy drivers/atm/iphase.c:148 ia_hack_tcq() warn: if(); drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?