[PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes: 17cf0ea455f1 ("batman-adv: tvlv - a

Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-14 Thread Antonio Quartulli
On 11/08/15 21:36, Sergei Shtylyov wrote: >> /* check if orig node candidate is running DAT */ >> -if (!(candidate->capabilities & BATADV_ORIG_CAPA_HAS_DAT)) >> +if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities))) > >() around the tst_bit() call not needed. Th

Re: [PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-11 Thread Sergei Shtylyov
Hello. On 08/11/2015 07:35 PM, Antonio Quartulli wrote: From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/t

[PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-11 Thread Antonio Quartulli
From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes: 17cf0ea455f1 ("batman-adv: tvlv - a