Re: [PATCH 03/12] net: igb: avoid using timespec

2015-10-02 Thread Richard Cochran
On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote: > I tried to use this pattern whenever I convert the 64-bit 'long long' > tv_sec member of 'struct timespec64' into a 32-bit number, to annotate > the loss of range. Sounds reasonable to me. > I have thought about defining separate h

Re: [PATCH 03/12] net: igb: avoid using timespec

2015-10-01 Thread Arnd Bergmann
On Thursday 01 October 2015 21:17:45 Richard Cochran wrote: > On Wed, Sep 30, 2015 at 01:26:33PM +0200, Arnd Bergmann wrote: > > diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c > > b/drivers/net/ethernet/intel/igb/igb_ptp.c > > index 5982f28d521a..c44df87c38de 100644 > > --- a/drivers/net/et

Re: [PATCH 03/12] net: igb: avoid using timespec

2015-10-01 Thread Richard Cochran
Arnd As author of these snippets, I went ahead and reviewed. I have one comment, below. Reviewed-by: Richard Cochran On Wed, Sep 30, 2015 at 01:26:33PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c > b/drivers/net/ethernet/intel/igb/igb_ptp.c > index 5982

[PATCH 03/12] net: igb: avoid using timespec

2015-09-30 Thread Arnd Bergmann
We want to deprecate the use of 'struct timespec' on 32-bit architectures, as it is will overflow in 2038. The igb driver uses it to read the current time, and can simply be changed to use ktime_get_real_ts64() instead. Because of hardware limitations, there is still an overflow in year 2106, whic