Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK patch, NA

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Auke Kok
Dave Jones wrote: On Tue, Sep 19, 2006 at 05:40:34PM -0400, Jeff Garzik wrote: > Dave Jones wrote: > > On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: > > > + add_taint(TAINT_MACHINE_CHECK); > > > > I object to this flag being abused this way. > > A corrup

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Dave Jones
On Tue, Sep 19, 2006 at 05:40:34PM -0400, Jeff Garzik wrote: > Dave Jones wrote: > > On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: > > > + add_taint(TAINT_MACHINE_CHECK); > > > > I object to this flag being abused this way. > > A corrupt EEPROM on a networ

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Jeff Garzik
Dave Jones wrote: On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: > > Refine cb cleaning debug printout and print out all cleaned cbs' status. Add > debug flag for EEPROM csum failures that were overridden by the user. > > Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> >

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Dave Jones
On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: > > Refine cb cleaning debug printout and print out all cleaned cbs' status. Add > debug flag for EEPROM csum failures that were overridden by the user. > > Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> > Signed-off-by: Auke K

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK patch, NAK description: taint

[PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Kok, Auke
Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |9 ++--- 1 files cha