subject:"\[PATCH 05\/10\] net\: ethernet\: i825xx\: Fix platform_get_irq's error checking"

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-02 Thread arvindY

Hi Sergei, On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote: Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-02 Thread Sergei Shtylyov

Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. The why you consider returning 0 a sign of failure? Signed-off-by:

[PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-02 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2