Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Evgeniy Polyakov
On Fri, Aug 10, 2007 at 01:55:07PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: > > This breaks compatibility. Add new socket option, which will really > > disable it and do all your logic, but not breaking existing > > applications. > > > > Is SO_TIMESTAMP2 a valid name? I can't imagine how

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Unai Uribarri
On vie, 2007-08-10 at 12:34 +0400, Evgeniy Polyakov wrote: > Hi Unai. > > On Thu, Aug 09, 2007 at 08:44:21PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > wrote: > > There is another option: > > > > 1. Move timestampt activation to packet_set_ring(), so it's activated > > only once at setup instead

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Evgeniy Polyakov
Hi Unai. On Thu, Aug 09, 2007 at 08:44:21PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: > There is another option: > > 1. Move timestampt activation to packet_set_ring(), so it's activated > only once at setup instead of every time a packet arrives. Does this break existing systems which ex

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
Do not enable timestamps automatically on mmap'ed AF_PACKET sockets. --- commit d1d6e6bf196e31b6306fd0fef95f4190983c8a86 tree 22637506c0aafeabfbe05faf5352d0358c4d9460 parent 6a302358d87fedaf7bda12b8e909265ebf1ce674 author Unai Uribarri <[EMAIL PROTECTED]> Tue, 31 Jul 2007 20:38:42 +0200 committer

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
There is another option: 1. Move timestampt activation to packet_set_ring(), so it's activated only once at setup instead of every time a packet arrives. 2. Fix sock_setsockopt() so setting SO_TIMESTAMP to 0 effectively disables timestamp. My first patch set did that. I sent that patches in mime

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Evgeniy Polyakov
On Thu, Aug 09, 2007 at 08:13:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: > On jue, 2007-08-09 at 18:33 +0400, Evgeniy Polyakov wrote: > > On Thu, Aug 09, 2007 at 04:21:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > > wrote: > > > The attached patch removes the automatic timestamp activ

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
On jue, 2007-08-09 at 18:33 +0400, Evgeniy Polyakov wrote: > On Thu, Aug 09, 2007 at 04:21:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > wrote: > > The attached patch removes the automatic timestamp activation, that > > only mmap'ed AF_PACKET sockets perform. I known it can break user > > applic

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Evgeniy Polyakov
On Thu, Aug 09, 2007 at 04:21:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: > The attached patch removes the automatic timestamp activation, that > only mmap'ed AF_PACKET sockets perform. I known it can break user > applications, but I believe that it's the correct solution. How tcpdump wi

[PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
Hello folks, I've discovered two strange behaviours (bugs?) about timestamp generation: 1. If a program opens an AF_PACKET socket and setup a reception ring with setsockopt(sock, SOL_PACKET, PACKET_RX_RING), timestamps are automatically (re)enabled at the reception of every packet. 2. Setting SO

[PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-08 Thread Unai Uribarri
Hello folks, I've discovered two strange behaviours (bugs?) about timestamp generation: 1. If a program opens an AF_PACKET socket and setup a reception ring with setsockopt(sock, SOL_PACKET, PACKET_RX_RING), timestamps are automatically (re)enabled at the reception of every packet. 2. Setting SO