Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-15 Thread Mike Snitzer
I'd very much like to help out. The rtnl assertion spew isn't instilling confidence in customers I've been working with. If you'd like to send me patches in private I'd help test them ASAP. Could you elaborate on the associated risk of _not_ fixing these issues? balance-alb _seems_ to be

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-15 Thread Jay Vosburgh
Mike Snitzer [EMAIL PROTECTED] wrote: I'd very much like to help out. The rtnl assertion spew isn't instilling confidence in customers I've been working with. If you'd like to send me patches in private I'd help test them ASAP. I'll send you some stuff off-list in a bit. Could you

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-14 Thread Mike Snitzer
Andy, Is there an updated version of this patch? Please advise, thanks. On 1/10/07, Andy Gospodarek [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 03:09:35PM -0800, Stephen Hemminger wrote: On Tue, 9 Jan 2007 17:59:01 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: These changes

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-14 Thread Andy Gospodarek
On 8/14/07, Mike Snitzer [EMAIL PROTECTED] wrote: Andy, Is there an updated version of this patch? Please advise, thanks. Mike, There is a version that Jay and I have been testing and if you would like to help out, we could probably send you some patches. Jay has split the entire patch

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-10 Thread Andy Gospodarek
On Tue, Jan 09, 2007 at 03:09:35PM -0800, Stephen Hemminger wrote: On Tue, 9 Jan 2007 17:59:01 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: These changes eliminate the messages indicating that the rtnetlink lock isn't held when bonding tries to change the MAC address of an interface.

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-10 Thread Stephen Hemminger
On Wed, 10 Jan 2007 14:33:58 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 03:09:35PM -0800, Stephen Hemminger wrote: On Tue, 9 Jan 2007 17:59:01 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: These changes eliminate the messages indicating that the

[PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Andy Gospodarek
These changes eliminate the messages indicating that the rtnetlink lock isn't held when bonding tries to change the MAC address of an interface. These calls generally come from timer-pops, but also from sysfs events since neither hold the rtnl lock. The spew generally looks something like

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2007 17:59:01 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: These changes eliminate the messages indicating that the rtnetlink lock isn't held when bonding tries to change the MAC address of an interface. These calls generally come from timer-pops, but also from sysfs events

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Jeff Garzik
Andy Gospodarek wrote: -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave) +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked) { struct slave *swap_slave; int i; Although this is not a direct NAK

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Andy Gospodarek
On Tue, Jan 09, 2007 at 06:13:55PM -0500, Jeff Garzik wrote: Andy Gospodarek wrote: -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave) +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked) { struct slave