Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-07 Thread Michal Kubecek
On Thu, Jan 07, 2016 at 03:37:26PM +0800, zhuyj wrote: > >If I read this right, whenever this state (link up but speed/duplex > >unknown) is entered, you'll keep writing this message into kernel log > >every miimon milliseconds until something changes. I'm not sure how long > >a NIC can stay in

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-07 Thread zhuyj
On 01/07/2016 03:59 PM, Michal Kubecek wrote: On Thu, Jan 07, 2016 at 03:37:26PM +0800, zhuyj wrote: If I read this right, whenever this state (link up but speed/duplex unknown) is entered, you'll keep writing this message into kernel log every miimon milliseconds until something changes. I'm

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-06 Thread zhuyj
, Boris (Wind River) Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode On 01/06/2016 09:26 AM, Tantilov, Emil S wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of zhuyj Sent: Monday, December 28, 2015 1:19 AM

RE: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-06 Thread Tantilov, Emil S
l S; Michal Kubecek; Jay Vosburgh >>> Cc: vfal...@gmail.com; go...@cumulusnetworks.com; >netdev@vger.kernel.org; >>> Shteinbock, Boris (Wind River) >>> Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode >>> >>> On 01/06/2

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-06 Thread zhuyj
Hi, Emil Would you like to help me to make tests with this patch? If the root cause is not the time span, I will make a new patch for this. Thanks a lot. Zhu Yanjun On 01/07/2016 02:15 PM, zyjzyj2...@gmail.com wrote: From: Zhu Yanjun In 802.3ad mode, the speed and

RE: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-06 Thread Tantilov, Emil S
ent: Monday, December 28, 2015 1:19 AM >>> To: Michal Kubecek; Jay Vosburgh >>> Cc: vfal...@gmail.com; go...@cumulusnetworks.com; >netdev@vger.kernel.org; >>> Shteinbock, Boris (Wind River) >>> Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-05 Thread zhuyj
@vger.kernel.org; Shteinbock, Boris (Wind River) Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode On 12/28/2015 04:43 PM, Michal Kubecek wrote: On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: <zyjzyj2...@gmail.com> wrote: In 802.3ad mode, the speed and

RE: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-05 Thread Tantilov, Emil S
teinbock, Boris (Wind River) >Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode > >On 12/28/2015 04:43 PM, Michal Kubecek wrote: >> On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: >>> <zyjzyj2...@gmail.com> wrote: >>>> I

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-28 Thread Michal Kubecek
On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: > wrote: > >In 802.3ad mode, the speed and duplex is needed. But in some NIC, > >there is a time span between NIC up state and getting speed and duplex. > >As such, sometimes a slave in 802.3ad mode is in up state

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-28 Thread zhuyj
On 12/28/2015 04:43 PM, Michal Kubecek wrote: On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: wrote: In 802.3ad mode, the speed and duplex is needed. But in some NIC, there is a time span between NIC up state and getting speed and duplex. As such, sometimes

[PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread zyjzyj2000
From: Zhu Yanjun In 802.3ad mode, the speed and duplex is needed. But in some NIC, there is a time span between NIC up state and getting speed and duplex. As such, sometimes a slave in 802.3ad mode is in up state without speed and duplex. This will make bonding in 802.3ad

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread Jay Vosburgh
wrote: >From: Zhu Yanjun > >In 802.3ad mode, the speed and duplex is needed. But in some NIC, >there is a time span between NIC up state and getting speed and duplex. >As such, sometimes a slave in 802.3ad mode is in up state without >speed and

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread zyjzyj2000
Hi, Jay Thanks for your reply. Yes. The NIC is a bit odd. We have to be compatible with it. I followed your advice to delay calling netif_carrier_on(). Changes: Delay calling netif_carrier_on(). Best Regards! Zhu Yanjun -- To unsubscribe from this list: send the line "unsubscribe netdev" in