答复: 答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-20 Thread 高峰
Re: 答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions On Wed, Jul 20, 2016 at 08:31:13AM +0800, 高峰 wrote: > Thanks Pablo. > > I had used the script "checkpatch.pl" to check the patch file. > There was no indentation error reported. > > So coul

Re: 答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-20 Thread Pablo Neira Ayuso
On Wed, Jul 20, 2016 at 08:31:13AM +0800, 高峰 wrote: > Thanks Pablo. > > I had used the script "checkpatch.pl" to check the patch file. > There was no indentation error reported. > > So could you give me more tails please or point one indentation error? > Then I could correct it by myself next

Re: 答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-20 Thread Pablo Neira Ayuso
On Wed, Jul 20, 2016 at 09:02:52AM +0800, 高峰 wrote: > Oh, thanks Liping. > I have not found the extra port styles are different of irc, sane and tftp > with ftp. > > Hi Pablo, > Then should I modify the original patch or send a new one? No need to resend, I have just sent an amendement that I'm

Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-20 Thread Pablo Neira Ayuso
On Wed, Jul 20, 2016 at 08:51:17AM +0800, Liping Zhang wrote: > 2016-07-18 11:39 GMT+08:00 : > > From: Gao Feng > > > > Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister > > functions to enhance the conntrack helper codes. > > I think this patch

答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-19 Thread 高峰
Ayuso <pa...@netfilter.org>; Patrick McHardy <ka...@trash.net>; netfilter-de...@vger.kernel.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; gfree.w...@gmail.com 主题: Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions 2016-07-18 11:39 GMT+08:00 <

Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-19 Thread Liping Zhang
2016-07-18 11:39 GMT+08:00 : > From: Gao Feng > > Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister > functions to enhance the conntrack helper codes. I think this patch is breaking something ... This irc: > - if (ports[i] ==

Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-19 Thread Pablo Neira Ayuso
On Mon, Jul 18, 2016 at 11:39:23AM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister > functions to enhance the conntrack helper codes. Applied, thanks. I have manually updated indentations to make it fit to our

[PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-17 Thread fgao
From: Gao Feng Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister functions to enhance the conntrack helper codes. Signed-off-by: Gao Feng --- include/net/netfilter/nf_conntrack_helper.h | 16 ++ net/netfilter/nf_conntrack_ftp.c|