Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-17 Thread Michal Hocko
On Fri 16-12-16 16:28:21, Alexei Starovoitov wrote: > On Sat, Dec 17, 2016 at 12:39:17AM +0100, Michal Hocko wrote: > > On Fri 16-12-16 15:23:42, Alexei Starovoitov wrote: > > > On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: > > > > On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote:

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Alexei Starovoitov
On Sat, Dec 17, 2016 at 12:39:17AM +0100, Michal Hocko wrote: > On Fri 16-12-16 15:23:42, Alexei Starovoitov wrote: > > On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: > > > On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote: > > > > On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Ho

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Daniel Borkmann
On 12/17/2016 12:23 AM, Alexei Starovoitov wrote: On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote: On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Hocko wrote: From: Michal Hocko 01b3f52157ff ("bpf: fix allocation warnings in

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Michal Hocko
On Fri 16-12-16 15:23:42, Alexei Starovoitov wrote: > On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: > > On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote: > > > On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > 01b3f52157ff (

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Alexei Starovoitov
On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: > On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote: > > On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > 01b3f52157ff ("bpf: fix allocation warnings in bpf maps and integer > > > over

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Michal Hocko
On Fri 16-12-16 10:02:10, Alexei Starovoitov wrote: > On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > 01b3f52157ff ("bpf: fix allocation warnings in bpf maps and integer > > overflow") has added checks for the maximum allocateable size. It > > (ab)used

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

2016-12-16 Thread Alexei Starovoitov
On Thu, Dec 15, 2016 at 05:47:21PM +0100, Michal Hocko wrote: > From: Michal Hocko > > 01b3f52157ff ("bpf: fix allocation warnings in bpf maps and integer > overflow") has added checks for the maximum allocateable size. It > (ab)used KMALLOC_SHIFT_MAX for that purpose. While this is not incorrect