Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-08-04 Thread Emmanuel Grumbach
On Tue, Aug 4, 2015 at 2:48 PM, Emmanuel Grumbach wrote: > On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko > wrote: >> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: >>> There is no need to use hex_dump_to_buffer() in the cases like this: >>> >>> hexdump_to_buffer(buf, len, 16, 1

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-08-04 Thread Emmanuel Grumbach
On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko wrote: > On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: >> There is no need to use hex_dump_to_buffer() in the cases like this: >> >> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /* >> len <= 16 >> */ >> s

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-08-04 Thread Andy Shevchenko
On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: > There is no need to use hex_dump_to_buffer() in the cases like this: > > hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /* > len <= 16 > */ > sprintf("%s\n", outbuf); > > since it maybe easily converted t

[PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-07-16 Thread Andy Shevchenko
There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len <= 16 */ sprintf("%s\n", outbuf); since it maybe easily converted to simple: sprintf("%*ph\n", len, buf); Note: it seems in one ca