Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-17 Thread Seewer Philippe
Don Fry wrote: I get the same results in my testing. Good catch on the coding error for ecmd.transciever. Without adding some more specific code to support the Allied Telesyn cards I don`t know how to get things to work without using ethtool. Maybe someone else has a better idea. Here is

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-17 Thread Don Fry
On Fri, Mar 17, 2006 at 05:13:24PM +0100, Seewer Philippe wrote: OK. applied it to 2.6.16-rc6. applies and works flawless. The new check_media function is subjectively slower than the older code without it but thats all I found. Tested with AT 2700FTX and 2701FTX. Both work and can be

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-17 Thread Philippe Seewer [swp2]
Don Fry wrote: On Fri, Mar 17, 2006 at 05:13:24PM +0100, Seewer Philippe wrote: OK. applied it to 2.6.16-rc6. applies and works flawless. The new check_media function is subjectively slower than the older code without it but thats all I found. Tested with AT 2700FTX and 2701FTX. Both

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-08 Thread Don Fry
On Mon, Feb 27, 2006 at 11:45:51AM +0100, Seewer Philippe wrote: OK, found it. The code in pcnet32_open assigns XCVR_INTERNAL to ecmd.port instead of ecmd.transceiver, making mii_ethtool_sset fail and leaving all phys configured to defaults. On the Allied Telesyn FTX cards this means to

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-27 Thread Seewer Philippe
Seewer Philippe wrote: Don Fry wrote: On Mon, Feb 20, 2006 at 04:30:22PM +0100, Seewer Philippe wrote: Basic result: Works perfectly (exceptions see below) out of the box Problem 1: During probe1, lp-options is silently overwritten with PCNET32_PORT_MII. Even setting the statement to

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-20 Thread Seewer Philippe
I am looking over this change and the following one, to try and understand what and why you made your changes. The change made by Thomas Bogendoerfer and modified by myself is much more flexible than your changes, in that they are not specific just to the Allied Telesyn boards with multiple

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-20 Thread Seewer Philippe
I'm probably stupid, but I really can't find that post. Could anyone repost please? found it (yes, this means i'm stupid) First of all, please consider all the patches i sent as junk. The mentioned patch is better than mine by a factor of a few thousands. I've tested the patch on

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-20 Thread Don Fry
On Mon, Feb 20, 2006 at 04:30:22PM +0100, Seewer Philippe wrote: Basic result: Works perfectly (exceptions see below) out of the box Problem 1: During probe1, lp-options is silently overwritten with PCNET32_PORT_MII. Even setting the statement to lp-options |= doesn't help mutch, the

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-18 Thread Seewer Philippe
I sent out a patch for testing on November 8 to netdev which is available on the archives, with a patch to support boards with multiple phys. I have received few comments on the code. Maybe you could test that code and see if it does what you need. I was waiting until 2.6.16 is final

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-17 Thread Don Fry
Philippe, On a purely mechanical note, the patches do not apply cleanly because of whitespace changes. Possibly your mailer changed tabs to spaces, which causes the patch not to apply, and also causes your patch to have different spacing than the rest of the file. The driver does not conform to

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-17 Thread Seewer Philippe
Don Fry wrote: Philippe, On a purely mechanical note, the patches do not apply cleanly because of whitespace changes. Possibly your mailer changed tabs to spaces, which causes the patch not to apply, and also causes your patch to have different spacing than the rest of the file. The

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-17 Thread Don Fry
I am removing linux-kernel from the mailing list, as this thread is more appropriate to netdev, and there is a lot more traffic on linux-kernel. On Fri, Feb 17, 2006 at 09:12:52PM +0100, Seewer Philippe wrote: Don Fry wrote: Philippe, On a purely mechanical note, the patches do not