Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread Christoph Hellwig
On Fri, Jul 28, 2006 at 01:28:32AM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 10:27:12 +0200 > > > We need a fixup patch for the existing wrong comments on dev_alloc_skb > > anyway - but if you prefer to respin the netdev_alloc_skb and have >

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 10:27:12 +0200 > We need a fixup patch for the existing wrong comments on dev_alloc_skb > anyway - but if you prefer to respin the netdev_alloc_skb and have > another patch to fixup the original comments I can do that aswell. I in

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread Christoph Hellwig
On Fri, Jul 28, 2006 at 01:24:24AM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 09:08:51 +0200 > > > Yes, Joe Perches already pointed that out in private. This typo is copy > > and pasted from the dev_alloc_skb kerneldoc, so this patch fixes up

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 09:08:51 +0200 > Yes, Joe Perches already pointed that out in private. This typo is copy > and pasted from the dev_alloc_skb kerneldoc, so this patch fixes up all > four occurances: > > Signed-off-by: Christoph Hellwig <[EMAIL PR

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 03:24:51PM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 26 Jul 2006 13:31:36 +0200 > > > + * %NULL is returned in there is no free memory. Although this function > > + * allocates memory it can be called from an interrupt. > ... > >

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 13:31:36 +0200 > + * %NULL is returned in there is no free memory. Although this function > + * allocates memory it can be called from an interrupt. ... > + * %NULL is returned in there is no free memory. Looks like a typo

[PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread Christoph Hellwig
Add a dev_alloc_skb variant that takes a struct net_device * paramater. For now that paramater is unused, but I'll use it to allocate the skb from node-local memory in a follow-up patch. Also there have been some other plans mentioned on the list that can use it. Signed-off-by: Christoph Hellwig