Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-03 Thread Neil Armstrong
On 10/03/2015 02:39 PM, Felix Fietkau wrote: > On 2015-10-02 15:30, Neil Armstrong wrote: >> On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: >>> On 10/2/2015 1:48 PM, Neil Armstrong wrote: >>> To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls.

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-03 Thread Felix Fietkau
On 2015-10-02 15:30, Neil Armstrong wrote: > On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: >> On 10/2/2015 1:48 PM, Neil Armstrong wrote: >> >>> To simplify and prevent memory leakage when unbinding, use >>> the devm_ memory allocation calls. >>> >>> Tested-by: Andrew Lunn >>>

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Sergei Shtylyov
On 10/2/2015 1:48 PM, Neil Armstrong wrote: To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Tested-by: Andrew Lunn Tested-by: Florian Fainelli Signed-off-by: Neil Armstrong ---

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Neil Armstrong
On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: > On 10/2/2015 1:48 PM, Neil Armstrong wrote: > >> To simplify and prevent memory leakage when unbinding, use >> the devm_ memory allocation calls. >> >> Tested-by: Andrew Lunn >> Tested-by: Florian Fainelli >>

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Sergei Shtylyov
On 10/2/2015 4:30 PM, Neil Armstrong wrote: To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Tested-by: Andrew Lunn Tested-by: Florian Fainelli Signed-off-by: Neil Armstrong ---

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Felix Fietkau
On 2015-10-02 12:48, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Tested-by: Andrew Lunn > Tested-by: Florian Fainelli > Signed-off-by: Neil Armstrong I

[PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Neil Armstrong
To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Tested-by: Andrew Lunn Tested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +++--- 1 file changed, 3

[RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-09-30 Thread Neil Armstrong
To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index c59fa5d..98f94c2

Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-09-30 Thread Andrew Lunn
Hi Neil I tested all three patches on a board with three switches. 1) Normal boot 2) Bad address set for the 3rd switch so that it was not found, so causing the probe to fail. No regressions observed. Tested-by: Andrew Lunn As Florian said, this is going in the right

Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-09-30 Thread Fabio Estevam
On Wed, Sep 30, 2015 at 5:21 AM, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Signed-off-by: Neil Armstrong > --- > net/dsa/dsa.c | 6 +++--- > 1 file changed, 3

Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-09-30 Thread Florian Fainelli
On 30/09/15 01:21, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Signed-off-by: Neil Armstrong For this entire series, on BCM7445 (using bcm_sf2) Tested-by: Florian Fainelli

Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-09-30 Thread Florian Fainelli
On 30/09/15 14:34, Fabio Estevam wrote: > On Wed, Sep 30, 2015 at 5:21 AM, Neil Armstrong > wrote: >> To simplify and prevent memory leakage when unbinding, use >> the devm_ memory allocation calls. >> >> Signed-off-by: Neil Armstrong >> --- >>