Re: [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-12-06 Thread Claudiu.Beznea
On 05.12.2018 22:32, David Miller wrote: > From: Anssi Hannula > Date: Fri, 30 Nov 2018 20:21:35 +0200 > >> @@ -682,6 +682,11 @@ static void macb_set_addr(struct macb *bp, struct >> macb_dma_desc *desc, dma_addr_ >> if (bp->hw_dma_cap & HW_DMA_CAP_64B) { >> desc_64 =

Re: [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-12-05 Thread David Miller
From: Anssi Hannula Date: Fri, 30 Nov 2018 20:21:35 +0200 > @@ -682,6 +682,11 @@ static void macb_set_addr(struct macb *bp, struct > macb_dma_desc *desc, dma_addr_ > if (bp->hw_dma_cap & HW_DMA_CAP_64B) { > desc_64 = macb_64b_desc(bp, desc); > desc_64->addrh =

Re: [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-12-05 Thread Anssi Hannula
On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: > Hi Anssi, Hi, and thanks for looking at these. > Few comments... Otherwise I tested this series on a SAMA5D2 Xplained and > SAMA5D4 Xplained under heavy traffic and it seems to behave OK. > > Thank you, > Claudiu Beznea > > On 30.11.2018

Re: [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-12-05 Thread Claudiu.Beznea
Hi Anssi, Few comments... Otherwise I tested this series on a SAMA5D2 Xplained and SAMA5D4 Xplained under heavy traffic and it seems to behave OK. Thank you, Claudiu Beznea On 30.11.2018 20:21, Anssi Hannula wrote: > 64-bit DMA addresses are split in upper and lower halves that are > written in

Re: [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-12-02 Thread Harini Katakam
On Fri, Nov 30, 2018 at 11:53 PM Anssi Hannula wrote: > > 64-bit DMA addresses are split in upper and lower halves that are > written in separate fields on GEM. For RX, bit 0 of the address is used > as the ownership bit (RX_USED). When the RX_USED bit is unset the > controller is allowed to

[PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA

2018-11-30 Thread Anssi Hannula
64-bit DMA addresses are split in upper and lower halves that are written in separate fields on GEM. For RX, bit 0 of the address is used as the ownership bit (RX_USED). When the RX_USED bit is unset the controller is allowed to write data to the buffer. The driver does not guarantee that the