[PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #3]

2007-03-20 Thread David Howells
Add blkcipher accessors for using kernel data directly without the use of scatter lists. Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use of DMA and hardware accelerators. A hardware accelerator may not be used to access any arbitrary piece of kernel memory lest it

[PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]

2007-03-16 Thread David Howells
Add blkcipher accessors for using kernel data directly without the use of scatter lists. Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use of DMA and hardware accelerators. A hardware accelerator may not be used to access any arbitrary piece of kernel memory lest it

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]

2007-03-16 Thread Christoph Hellwig
On Fri, Mar 16, 2007 at 12:50:16PM +, David Howells wrote: Add blkcipher accessors for using kernel data directly without the use of scatter lists. I don't quite understand all these indirections. What's the problem with just having a helper that builds the scatterlist for you? Also add

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]

2007-03-16 Thread David Howells
Christoph Hellwig [EMAIL PROTECTED] wrote: I don't quite understand all these indirections. What's the problem with just having a helper that builds the scatterlist for you? I was trying to avoid building a scatterlist completely. There's not much point because the scatterlist approach

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]

2007-03-16 Thread Alan Cox
very odd line split It's not really odd. The static and inline don't actually add anything to the function template. They're merely scope limiters / optimisation controllers, and so make a lot of sense placed on their own line. As do many things but the goal of the coding style is

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]

2007-03-16 Thread David Howells
Alan Cox [EMAIL PROTECTED] wrote: As do many things but the goal of the coding style is consistency and almost all other code doesn't have the static inline wasting an extra display line. Actually it doesn't waste an extra display line. Either the static inline is on a line of its own, or

[PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-03-08 Thread David Howells
Add blkcipher accessors for using kernel data directly without the use of scatter lists. Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use of DMA and hardware accelerators. A hardware accelerator may not be used to access any arbitrary piece of kernel memory lest it

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-03-08 Thread Valdis . Kletnieks
On Thu, 08 Mar 2007 22:48:29 GMT, David Howells said: diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 779aa78..ce092fe 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -40,7 +40,10 @@ #define CRYPTO_ALG_LARVAL0x0010 #define