Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-12 Thread Florian Fainelli
Le 09/06/2016 02:44, LABBE Corentin a écrit : > Hello > > I agree to all your comments, but for some I have additionnal questions > > On Mon, Jun 06, 2016 at 11:25:15AM -0700, Florian Fainelli wrote: >> On 06/03/2016 02:56 AM, LABBE Corentin wrote: >> >> [snip] >> >>> + >>> +/* The datasheet said

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-09 Thread LABBE Corentin
Hello I agree to all your comments, but for some I have additionnal questions On Mon, Jun 06, 2016 at 11:25:15AM -0700, Florian Fainelli wrote: > On 06/03/2016 02:56 AM, LABBE Corentin wrote: > > [snip] > > > + > > +/* The datasheet said that each descriptor can transfers up to 4096bytes > > +

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-06 Thread Florian Fainelli
On 06/03/2016 02:56 AM, LABBE Corentin wrote: > This patch add support for sun8i-emac ethernet MAC hardware. > It could be found in Allwinner H3/A83T/A64 SoCs. > > It supports 10/100/1000 Mbit/s speed with half/full duplex. > It can use an internal PHY (MII 10/100) or an external PHY > via RGMII/R

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-06 Thread LABBE Corentin
On Sun, Jun 05, 2016 at 11:32:11PM +0100, André Przywara wrote: > On 03/06/16 10:56, LABBE Corentin wrote: > > Hi, > > first: thanks for posting this and the time and work that you spent on > it. With the respective DT nodes this works for me on the Pine64 and > turns this board eventually into s

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-05 Thread Chen-Yu Tsai
On Mon, Jun 6, 2016 at 6:32 AM, André Przywara wrote: > On 03/06/16 10:56, LABBE Corentin wrote: > > Hi, > > first: thanks for posting this and the time and work that you spent on > it. With the respective DT nodes this works for me on the Pine64 and > turns this board eventually into something us

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-05 Thread André Przywara
On 03/06/16 10:56, LABBE Corentin wrote: Hi, first: thanks for posting this and the time and work that you spent on it. With the respective DT nodes this works for me on the Pine64 and turns this board eventually into something useful. Some comments below: > This patch add support for sun8i-ema

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-03 Thread David Miller
From: LABBE Corentin Date: Fri, 3 Jun 2016 11:56:26 +0200 > +static int nbdesc_tx = 256; > +module_param(nbdesc_tx, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(nbdesc_tx, "Number of descriptors in the TX list"); > +static int nbdesc_rx = 128; > +module_param(nbdesc_rx, int, S_IRUGO | S_IWUSR);

[PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-03 Thread LABBE Corentin
This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via RGMII/RMII. Signed-off-by: LABBE Corentin --- drivers/net/ethe