Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-14 Thread Stephen Hemminger
On Tue, 13 Mar 2018 14:14:14 -0700 Jesse Brandeburg wrote: > Maybe it's just that I've been doing this too long, but I regularly > (and many other customers/users do as well) depend on the ethtool stats > being atomically updated w.r.t. each other. This means that if

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Toshiaki Makita
On 2018/03/14 6:14, Jesse Brandeburg wrote: > which iproute2 tool shows the /proc/net/dev stats? ip -s -s link show -- Toshiaki Makita

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Eric Dumazet
On 03/13/2018 02:14 PM, Jesse Brandeburg wrote: On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: Yes, this is a recurring mistake See commit bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet statistics of netdev" Thanks for the pointer,

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Jesse Brandeburg
On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: > > Yes, this is a recurring mistake > > See commit > bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet > statistics of netdev" Thanks for the pointer, that was a useful thread to review. I

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread David Miller
From: "Venkataramanan, Anirudh" Date: Tue, 13 Mar 2018 19:05:19 + > Thanks for the feedback. I am not sure I understand what's being asked > here. Do you mean to say that standard netdev stats should not be > printed when we do ethtool -S or something else?

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Venkataramanan, Anirudh
On Sat, 2018-03-10 at 08:42 -0800, Stephen Hemminger wrote: > On Fri, 9 Mar 2018 09:21:33 -0800 > Anirudh Venkataramanan wrote: > > > + /* VSI stats */ > > + struct rtnl_link_stats64 net_stats; > > + struct rtnl_link_stats64 net_stats_prev; > > + struct

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Eric Dumazet
On 03/13/2018 12:05 PM, Venkataramanan, Anirudh wrote: On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote: On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: +static const struct ice_stats ice_net_stats[] = { + ICE_NETDEV_STAT(rx_packets), +

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Venkataramanan, Anirudh
On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote: > On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: > > +static const struct ice_stats ice_net_stats[] = { > > + ICE_NETDEV_STAT(rx_packets), > > + ICE_NETDEV_STAT(tx_packets), > > + ICE_NETDEV_STAT(rx_bytes), > > +

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-10 Thread Stephen Hemminger
On Fri, 9 Mar 2018 09:21:33 -0800 Anirudh Venkataramanan wrote: > + /* VSI stats */ > + struct rtnl_link_stats64 net_stats; > + struct rtnl_link_stats64 net_stats_prev; > + struct ice_eth_stats eth_stats; > + struct ice_eth_stats

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-10 Thread Stephen Hemminger
On Fri, 9 Mar 2018 09:21:33 -0800 Anirudh Venkataramanan wrote: > + /* VSI stats */ > + struct rtnl_link_stats64 net_stats; > + struct rtnl_link_stats64 net_stats_prev; > + struct ice_eth_stats eth_stats; > + struct ice_eth_stats

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-09 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Mar 2018 15:14:28 -0800 > On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: >> +static const struct ice_stats ice_net_stats[] = { >> +ICE_NETDEV_STAT(rx_packets), >> +ICE_NETDEV_STAT(tx_packets), >> +

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-09 Thread Jakub Kicinski
On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: > +static const struct ice_stats ice_net_stats[] = { > + ICE_NETDEV_STAT(rx_packets), > + ICE_NETDEV_STAT(tx_packets), > + ICE_NETDEV_STAT(rx_bytes), > + ICE_NETDEV_STAT(tx_bytes), > + ICE_NETDEV_STAT(rx_errors),

Re: [PATCH 12/15] ice: Add stats and ethtool support

2018-03-09 Thread Andrew Lunn
On Fri, Mar 09, 2018 at 09:21:33AM -0800, Anirudh Venkataramanan wrote: > This patch implements a watchdog task to get packet statistics from > the device. > > This patch also adds support for the following ethtool operations: > > ethtool devname > ethtool -s devname [msglvl N] [msglevel type

[PATCH 12/15] ice: Add stats and ethtool support

2018-03-09 Thread Anirudh Venkataramanan
This patch implements a watchdog task to get packet statistics from the device. This patch also adds support for the following ethtool operations: ethtool devname ethtool -s devname [msglvl N] [msglevel type on|off] ethtool -g|--show-ring devname ethtool -G|--set-ring devname [rx N] [tx N]