Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-10 Thread Stephen Hemminger
On Fri, 9 Nov 2007 16:40:05 -0600 [EMAIL PROTECTED] (Linas Vepstas) wrote: On Fri, Nov 09, 2007 at 06:02:34PM +0100, Ingo Oeser wrote: Linas Vepstas schrieb: + * napi_enabled_p - return non-zero if napi enabled + * + * Mnemonic: _p stands for predicate, returning a yes/no +

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-09 Thread Ingo Oeser
Hi Linas, Linas Vepstas schrieb: Index: linux-2.6.23-rc8-mm1/include/linux/netdevice.h === --- linux-2.6.23-rc8-mm1.orig/include/linux/netdevice.h 2007-09-26 15:07:05.0 -0500 +++

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-09 Thread Linas Vepstas
On Fri, Nov 09, 2007 at 06:02:34PM +0100, Ingo Oeser wrote: Linas Vepstas schrieb: + * napi_enabled_p - return non-zero if napi enabled + * + * Mnemonic: _p stands for predicate, returning a yes/no + * answer to the question. Call it is_napi_enabled() an nobody will ask :-) Heh. The

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-07 Thread Kok, Auke
[adding netdev, jeff G to the Cc] Linas Vepstas wrote: On Wed, Nov 07, 2007 at 01:50:17PM -0800, Kok, Auke wrote: Linas Vepstas wrote: If a PCI bus error is encountered during device open, the error recovery routines will attempt to close the device. If napi has not yet been enabled, the

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-07 Thread Linas Vepstas
On Wed, Nov 07, 2007 at 02:45:18PM -0800, Kok, Auke wrote: [adding netdev, jeff G to the Cc] Linas Vepstas wrote: On Wed, Nov 07, 2007 at 01:50:17PM -0800, Kok, Auke wrote: Linas Vepstas wrote: If a PCI bus error is encountered during device open, the error recovery routines will

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-07 Thread Stephen Hemminger
On Wed, 07 Nov 2007 14:45:18 -0800 Kok, Auke [EMAIL PROTECTED] wrote: [adding netdev, jeff G to the Cc] Linas Vepstas wrote: On Wed, Nov 07, 2007 at 01:50:17PM -0800, Kok, Auke wrote: Linas Vepstas wrote: If a PCI bus error is encountered during device open, the error recovery