Hi Neil,
Thank you for the reply.
Neil Brown wrote:
I think this patch is unnecessary and hence not wanted.
The getfs / getfs calls should be considered legacy calls.
Adding functionality to them is not appropriate.
I agree with that.
But I don't think we really add functionality here.
Mo
On Wed, Oct 31, 2007 at 10:06:18AM +0100, Aurélien Charbon wrote:
> Thank you Brian
> Sorry, I did not see what you sent.
>
> I have tested it with an IPv4 configuration. It's OK.
> So Neil, Bruce, you can take this one for review.
Did you miss Neil's question about the nfsctl stuff? (Do we reall
Thank you Brian
Sorry, I did not see what you sent.
I have tested it with an IPv4 configuration. It's OK.
So Neil, Bruce, you can take this one for review.
fs/nfsd/export.c |9 ++-
fs/nfsd/nfsctl.c | 42 --
include/linux/sunrpc/svcauth.h |5 +
inclu
Aurélien Charbon wrote:
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
It updates write_getfd and write_getfd to accept IPv6 addresses.
Applies on a kernel including ip_map cache modifications
Both patches still have bugs, I think the p
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
It updates write_getfd and write_getfd to accept IPv6 addresses.
Applies on a kernel including ip_map cache modifications
Tests: tested with only IPv4 network and basic nfs ops (mount, file
On Monday October 22, [EMAIL PROTECTED] wrote:
> Here is a second missing part of the IPv6 support in NFS server code
> concerning knfd syscall interface.
> It updates write_getfd and write_getfd to accept IPv6 addresses.
Sorry for not replying to this earlier - I saw the Oct 12 post and
thought
Hi Aurelien,
This is a combination of your two patches into one, cleaned-up with all
my complaints. I also added an ipv6_addr_set_v4mapped() inline after
someone else here convinced me it gets rid of a lot of cruft from the
code. The DCCP, etc. code can be cleaned-up later if this gets accep
Hi Aurelien,
Again, a few more comments.
I might just modify these in my own tree and send out a patch that
combines both into one, it might be less work.
@@ -229,9 +229,20 @@ static ssize_t write_getfs(struct file *
return -EINVAL;
data = (struct nfsctl_fsparm*)buf;
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
It updates write_getfd and write_getfd to accept IPv6 addresses.
I've updated it according to Brian's comments, and removed some unused code.
Applies on a kernel including ip_map cache modifi
Hi Aurelien,
Comments in-line.
Aurélien Charbon wrote:
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
-struct sockaddr_in *sin;
+struct sockaddr_in6 *sin, sin6_storage;
Nit, should call this sin6 now.
@@ -228,9 +228,20 @@ s
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
It updates write_getfd and write_getfd to accept IPv6 addresses.
Applies on a kernel including ip_map cache modifications
Tests: tested with only IPv4 network and basic nfs ops (mount, file c
11 matches
Mail list logo
