Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-17 Thread Jon Mason
On Mon, Jul 17, 2017 at 2:37 PM, Abhishek Shah wrote: > Hi Jon, > >> This also will need to be added to >> drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver >> will no longer work for those platforms. Since this was already >> accepted, please push

Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-17 Thread Abhishek Shah
Hi Jon, > This also will need to be added to > drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver > will no longer work for those platforms. Since this was already > accepted, please push out a fix ASAP. > I do not see how the bcma driver [bgmac-bcma.c] will no longer work. The

Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-17 Thread Jon Mason
On Thu, Jul 13, 2017 at 3:04 PM, Abhishek Shah wrote: > IDM operations are usually one time ops and should be done in > firmware itself. Driver is not supposed to touch IDM registers. > > However, for some SoCs', driver is performing IDM read/writes. > So this patch

[PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-13 Thread Abhishek Shah
IDM operations are usually one time ops and should be done in firmware itself. Driver is not supposed to touch IDM registers. However, for some SoCs', driver is performing IDM read/writes. So this patch masks IDM operations in case firmware is taking care of IDM operations. Signed-off-by: