Re: [PATCH 2/5 net-next] inet: kill smallest_size and smallest_port

2016-12-21 Thread Josef Bacik
On Wed, Dec 21, 2016 at 1:30 PM, David Miller wrote: From: Josef Bacik Date: Tue, 20 Dec 2016 15:07:01 -0500 In inet_csk_get_port we seem to be using smallest_port to figure out where the best place to look for a SO_REUSEPORT sk that matches with an existing set of SO_REUSEPORT's. Howev

Re: [PATCH 2/5 net-next] inet: kill smallest_size and smallest_port

2016-12-21 Thread Eric Dumazet
On Wed, 2016-12-21 at 13:30 -0500, David Miller wrote: > From: Josef Bacik > Date: Tue, 20 Dec 2016 15:07:01 -0500 > > > In inet_csk_get_port we seem to be using smallest_port to figure out where > > the > > best place to look for a SO_REUSEPORT sk that matches with an existing set > > of > > S

Re: [PATCH 2/5 net-next] inet: kill smallest_size and smallest_port

2016-12-21 Thread David Miller
From: Josef Bacik Date: Tue, 20 Dec 2016 15:07:01 -0500 > In inet_csk_get_port we seem to be using smallest_port to figure out where the > best place to look for a SO_REUSEPORT sk that matches with an existing set of > SO_REUSEPORT's. However if we get to the logic > > if (smallest_size != -1)

[PATCH 2/5 net-next] inet: kill smallest_size and smallest_port

2016-12-20 Thread Josef Bacik
In inet_csk_get_port we seem to be using smallest_port to figure out where the best place to look for a SO_REUSEPORT sk that matches with an existing set of SO_REUSEPORT's. However if we get to the logic if (smallest_size != -1) { port = smallest_port; goto have_port; } we will d