Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-08-10 Thread Luis R. Rodriguez
On Fri, Jun 30, 2017 at 11:35:41PM +0200, Arend van Spriel wrote: > On 23-06-17 23:53, Luis R. Rodriguez wrote: > > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: > >>> Since no upstream delta is needed for firmwared I'd like to

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-06-30 Thread Arend van Spriel
On 23-06-17 23:53, Luis R. Rodriguez wrote: > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: >>> Since no upstream delta is needed for firmwared I'd like to first encourage >>> evaluating the above. While distributions don't carry

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-06-23 Thread Luis R. Rodriguez
On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > On 16-5-2017 1:13, Luis R. Rodriguez wrote: > > Since no upstream delta is needed for firmwared I'd like to first encourage > > evaluating the above. While distributions don't carry it yet that may be > > seen as > > an issue but

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Bjorn Andersson
On Wed 17 May 05:53 PDT 2017, Pali Roh?r wrote: > On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > > Now for N900 case there is a similar scenario > > > > > alhtough it has additional requirement to go to user-space due

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 15:21 +0200, Pali Rohár wrote: > On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > > > In fact, why should the *driver* care either? IOW - why should > > > > "request_firmware_prefer_user()" even exist? >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > In fact, why should the *driver* care either? IOW - why should > > > "request_firmware_prefer_user()" even exist? > > > > There are default/example NVS data, which are stored in

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > In fact, why should the *driver* care either? IOW - why should > > "request_firmware_prefer_user()" even exist? > > There are default/example NVS data, which are stored in /lib/firmware > and installed by linux-firmware package. [...] Oh,

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > Now for N900 case there is a similar scenario > > > > alhtough it has additional requirement to go to user-space due to > > > > need to use a proprietary library to obtain

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > Now for N900 case there is a similar scenario > > > alhtough it has additional requirement to go to user-space due to > > > need to use a proprietary library to obtain the NVS calibration > > > data. My thought: Why should

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-16 Thread Luis R. Rodriguez
On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > On 16-5-2017 1:13, Luis R. Rodriguez wrote: > > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > >> try again.. replacing email address from Michał > >> On 12-5-2017 22:55, Arend Van Spriel wrote: > >>> Let me

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-16 Thread Arend Van Spriel
On 16-5-2017 1:13, Luis R. Rodriguez wrote: > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: >> try again.. replacing email address from Michał >> On 12-5-2017 22:55, Arend Van Spriel wrote: >>> Let me explain the idea to refresh your memory (and mine). It started >>> when we

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-15 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > try again.. replacing email address from Michał > On 12-5-2017 22:55, Arend Van Spriel wrote: > > Let me explain the idea to refresh your memory (and mine). It started > > when we were working on adding driver support for OpenWrt

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-12 Thread Arend Van Spriel
On 4-5-2017 4:28, Luis R. Rodriguez wrote: > On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: >> On 3-1-2017 18:59, Luis R. Rodriguez wrote: >>> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: Right question is "should we solve it without user-space help"?

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-03 Thread Luis R. Rodriguez
On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: > On 3-1-2017 18:59, Luis R. Rodriguez wrote: > > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: > >> > >> Right question is "should we solve it without user-space help"? > >> > >> Answer is no, too. Way too complex.

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-03 Thread Arend Van Spriel
On 3-1-2017 18:59, Luis R. Rodriguez wrote: > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >> >> Right question is "should we solve it without user-space help"? >> >> Answer is no, too. Way too complex. Yes, it would be nice if hardware >> was designed in such a way that getting

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-02-01 Thread Michal Kazior
On 1 February 2017 at 09:33, Pali Rohár wrote: > On Tuesday 31 January 2017 07:59:18 Tony Lindgren wrote: >> * Kalle Valo [170130 22:36]: [...] >> > * before distro updates linux-firmware create yours own deb/rpm/whatever >> > package

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-02-01 Thread Pali Rohár
On Tuesday 31 January 2017 07:59:18 Tony Lindgren wrote: > * Kalle Valo [170130 22:36]: > > Tony Lindgren writes: > > > > > * Pavel Machek [170127 11:41]: > > >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > > >> > Pali Rohár

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-31 Thread Tony Lindgren
* Kalle Valo [170130 22:36]: > Tony Lindgren writes: > > > * Pavel Machek [170127 11:41]: > >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > >> > Pali Rohár writes: > >> > > >> > > On Friday 27 January 2017

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-30 Thread Kalle Valo
Tony Lindgren writes: > * Pavel Machek [170127 11:41]: >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: >> > Pali Rohár writes: >> > >> > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: >> > >> Pali Rohár

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-30 Thread Tony Lindgren
* Pavel Machek [170127 11:41]: > On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > > Pali Rohár writes: > > > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > > >> Pali Rohár writes: > > >> > > >> > 2) It was already tested

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-30 Thread Pali Rohár
On Monday 30 January 2017 18:53:09 Tony Lindgren wrote: > * Pavel Machek [170127 11:41]: > > On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > > > Pali Rohár writes: > > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > > > >> Pali Rohár

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-29 Thread Luis R. Rodriguez
On Fri, Jan 27, 2017 at 02:11:46PM +0100, Pali Rohár wrote: > So there are only two options: > > 1) Disallow it and so these users will have non-working wifi. > > 2) Allow those data to be used as fallback mechanism. There is one "custom fallback" user in kernel which we recently determined was

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Arend Van Spriel
On 27-1-2017 8:33, Kalle Valo wrote: > Pali Rohár writes: > >> NVS calibration data for wl1251 are model specific. Every one device with >> wl1251 chip has different and calibrated in factory. >> >> Not all wl1251 chips have own EEPROM where are calibration data stored. And

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pavel Machek
On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > Pali Rohár writes: > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >> > 2) It was already tested that example NVS data can be used for N900 e.g. > >> > for SSH

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 17:23:07 Kalle Valo wrote: > Pali Rohár writes: > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >> > 2) It was already tested that example NVS data can be used for N900 e.g. > >> >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Kalle Valo
Pali Rohár writes: > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: >> Pali Rohár writes: >> >> > 2) It was already tested that example NVS data can be used for N900 e.g. >> > for SSH connection. If real correct data are not available it is

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 13:53:28 Arend Van Spriel wrote: > On 27-1-2017 13:26, Kalle Valo wrote: > > Pali Rohár writes: > > > >> On Friday 27 January 2017 13:49:03 Kalle Valo wrote: > >>> Pali Rohár writes: > >>> > > So > > for those other

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > Pali Rohár writes: > > > On Friday 27 January 2017 13:49:03 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >> >> So > >> >> for those other platforms there will be a delay waiting for user-mode

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Arend Van Spriel
On 27-1-2017 13:26, Kalle Valo wrote: > Pali Rohár writes: > >> On Friday 27 January 2017 13:49:03 Kalle Valo wrote: >>> Pali Rohár writes: >>> > So > for those other platforms there will be a delay waiting for user-mode > helper to fail,

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Kalle Valo
Pali Rohár writes: > On Friday 27 January 2017 13:49:03 Kalle Valo wrote: >> Pali Rohár writes: >> >> >> So >> >> for those other platforms there will be a delay waiting for user-mode >> >> helper to fail, before trying to get nvs file from

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pavel Machek
Hi! > > You are probably saying that on your platform you can not remove > > anything from /lib/firmware, right? I don't see how you come from "it is > > part of firmware package" to "removing is not possible". Trying to > > understand this and it makes no sense. > > It is already in linux

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 13:49:03 Kalle Valo wrote: > Pali Rohár writes: > > >> So > >> for those other platforms there will be a delay waiting for user-mode > >> helper to fail, before trying to get nvs file from /lib/firmware. > > > > Yes, there will be. But there is no

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Kalle Valo
Pali Rohár writes: >> So >> for those other platforms there will be a delay waiting for user-mode >> helper to fail, before trying to get nvs file from /lib/firmware. > > Yes, there will be. But there is no easy way to fix this problem that > kernel is trying to use

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 11:19:25 Arend Van Spriel wrote: > On 27-1-2017 11:10, Pali Rohár wrote: > > On Friday 27 January 2017 11:05:32 Arend Van Spriel wrote: > >> On 27-1-2017 10:43, Pali Rohár wrote: > >>> On Friday 27 January 2017 09:33:40 Kalle Valo wrote: > Pali Rohár

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Arend Van Spriel
On 27-1-2017 11:10, Pali Rohár wrote: > On Friday 27 January 2017 11:05:32 Arend Van Spriel wrote: >> On 27-1-2017 10:43, Pali Rohár wrote: >>> On Friday 27 January 2017 09:33:40 Kalle Valo wrote: Pali Rohár writes: > NVS calibration data for wl1251 are model

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 11:05:32 Arend Van Spriel wrote: > On 27-1-2017 10:43, Pali Rohár wrote: > > On Friday 27 January 2017 09:33:40 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >>> NVS calibration data for wl1251 are model specific. Every one device with > >>>

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Arend Van Spriel
On 27-1-2017 10:43, Pali Rohár wrote: > On Friday 27 January 2017 09:33:40 Kalle Valo wrote: >> Pali Rohár writes: >> >>> NVS calibration data for wl1251 are model specific. Every one device with >>> wl1251 chip has different and calibrated in factory. >>> >>> Not all wl1251

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pali Rohár
On Friday 27 January 2017 09:33:40 Kalle Valo wrote: > Pali Rohár writes: > > > NVS calibration data for wl1251 are model specific. Every one device with > > wl1251 chip has different and calibrated in factory. > > > > Not all wl1251 chips have own EEPROM where are

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-26 Thread Kalle Valo
Pali Rohár writes: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > > Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place.

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-03 Thread Luis R. Rodriguez
On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: > > Right question is "should we solve it without user-space help"? > > Answer is no, too. Way too complex. Yes, it would be nice if hardware > was designed in such a way that getting calibration data from kernel > is easy, and if you

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-26 Thread Pavel Machek
On Sun 2016-12-25 21:15:40, Arend Van Spriel wrote: > On 24-12-2016 17:52, Pali Rohár wrote: > > NVS calibration data for wl1251 are model specific. Every one device with > > wl1251 chip has different and calibrated in factory. > > > > Not all wl1251 chips have own EEPROM where are calibration

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-26 Thread Pali Rohár
On Monday 26 December 2016 16:43:53 Pavel Machek wrote: > Hi! > > > > > NVS calibration data for wl1251 are model specific. Every one > > > > device with wl1251 chip has different and calibrated in > > > > factory. > > > > > > > > Not all wl1251 chips have own EEPROM where are calibration data >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-26 Thread Pavel Machek
Hi! > > > NVS calibration data for wl1251 are model specific. Every one > > > device with wl1251 chip has different and calibrated in factory. > > > > > > Not all wl1251 chips have own EEPROM where are calibration data > > > stored. And in that case there is no "standard" place. Every > > >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-25 Thread Pali Rohár
On Sunday 25 December 2016 21:15:40 Arend Van Spriel wrote: > On 24-12-2016 17:52, Pali Rohár wrote: > > NVS calibration data for wl1251 are model specific. Every one > > device with wl1251 chip has different and calibrated in factory. > > > > Not all wl1251 chips have own EEPROM where are

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-25 Thread Arend Van Spriel
On 24-12-2016 17:52, Pali Rohár wrote: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > > Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place.

[PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-24 Thread Pali Rohár
NVS calibration data for wl1251 are model specific. Every one device with wl1251 chip has different and calibrated in factory. Not all wl1251 chips have own EEPROM where are calibration data stored. And in that case there is no "standard" place. Every device has stored them on different place