Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 01:33:40PM -0700, Eric Dumazet wrote: > On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: > > > lpaa5:~# tc qd sh dev eth1 > > qdisc mq 0: root > > qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 > > priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 qu

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: > lpaa5:~# tc qd sh dev eth1 > qdisc mq 0: root > qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 > priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140 > qdisc fq 0: parent :3 limit 1p flo

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 22:21 +0200, Phil Sutter wrote: > On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote: > [...] > > I'll start implementing the above immediately, but would appreciate to > > hear your comments on it meanwhile. I wonder especially what makes the > > difference between p

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote: [...] > I'll start implementing the above immediately, but would appreciate to > hear your comments on it meanwhile. I wonder especially what makes the > difference between pfifo and pfifo_fast and why the latter can't be > selected expli

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
Hi, On Tue, Aug 18, 2015 at 07:47:28AM -0700, Eric Dumazet wrote: > On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: > > Due to the introduction of IFF_NO_QUEUE, there is a better way for > > drivers to indicate that no qdisc should be attached by default. Though, > > the old convention can't

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-18 Thread Phil Sutter
On Tue, Aug 18, 2015 at 07:47:28AM -0700, Eric Dumazet wrote: > On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: > > Due to the introduction of IFF_NO_QUEUE, there is a better way for > > drivers to indicate that no qdisc should be attached by default. Though, > > the old convention can't be d

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-18 Thread Eric Dumazet
On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: > Due to the introduction of IFF_NO_QUEUE, there is a better way for > drivers to indicate that no qdisc should be attached by default. Though, > the old convention can't be dropped since ignoring that setting would > break drivers still using i

[PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-18 Thread Phil Sutter
Due to the introduction of IFF_NO_QUEUE, there is a better way for drivers to indicate that no qdisc should be attached by default. Though, the old convention can't be dropped since ignoring that setting would break drivers still using it. Instead, add a warning so out-of-tree driver maintainers ge