RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> It's not being allocated at "compile time", it's being > allocated linearly into one block of ram in order to avoid > pointer derefs but it's still "dynamic" in that the size > isn't known until the alloc_netdev() call. > > We do this trick all over the networking, TCP sockets are 3 > or 4 d

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 13:01:18 -0700 > I've been thinking about this more today, so please bear with me if I'm > missing something. Right now, with how qdisc_restart() is running, we'd > definitely call netif_subqueue_stopped(dev, skb->queue_map

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 11:42:29 -0700 > > > + > > + /* The TX queue control structures */ > > + struct net_device_subqueue *egress_subqueue; > > + int egress_subqueue_count; > > Since every net device will have at

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 11:42:29 -0700 > > > + > > + /* The TX queue control structures */ > > + struct net_device_subqueue *egress_subqueue; > > + int egress_subqueue_count; > > Since every net device will have at

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread David Miller
From: PJ Waskiewicz <[EMAIL PROTECTED]> Date: Mon, 18 Jun 2007 11:42:29 -0700 > + > + /* The TX queue control structures */ > + struct net_device_subqueue *egress_subqueue; > + int egress_subqueue_count; Since every net device will have at least one su

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: /* Functions used for multicast support */ diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index e7367c7..8bcd870 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t; * @pk

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread Waskiewicz Jr, Peter P
> PJ Waskiewicz wrote: > > Add the multiqueue hardware device support API to the core network > > stack. Allow drivers to allocate multiple queues and > manage them at > > the netdev level if they choose to do so. > > > > Should be 2/3 and qdisc changes should be 3/3. Well actually > the q

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread Patrick McHardy
PJ Waskiewicz wrote: Add the multiqueue hardware device support API to the core network stack. Allow drivers to allocate multiple queues and manage them at the netdev level if they choose to do so. Should be 2/3 and qdisc changes should be 3/3. Well actually the qdisc sch_generic changes b

[PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread PJ Waskiewicz
Add the multiqueue hardware device support API to the core network stack. Allow drivers to allocate multiple queues and manage them at the netdev level if they choose to do so. Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]> --- include/linux/etherdevice.h |3 +- include/linux/netd