[PATCH 3/7] CAN: Add raw protocol

2007-11-16 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 763 +++

[PATCH 3/7] CAN: Add raw protocol

2007-11-14 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 811 +++

[PATCH 3/7] CAN: Add raw protocol

2007-10-05 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 810 +++

Re: [PATCH 3/7] CAN: Add raw protocol

2007-10-04 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > +static inline struct raw_sock *raw_sk(const struct sock *sk) > > +{ > > + return (struct raw_sock *)sk; > > +} > > > What if I want to do some kernel module that uses INET raw sockets > (include/net/icmp.h) and CAN raw sockets? Namespac

Re: [PATCH 3/7] CAN: Add raw protocol

2007-10-02 Thread Oliver Hartkopp
Arnaldo Carvalho de Melo wrote: Em Tue, Oct 02, 2007 at 03:10:09PM +0200, Urs Thuermann escreveu: + + if (ro->bound && ro->ifindex) + dev = dev_get_by_index(&init_net, ro->ifindex); dev_get_by_index can fail, are you sure that raw_enable_filters can

Re: [PATCH 3/7] CAN: Add raw protocol

2007-10-02 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2007 at 03:10:09PM +0200, Urs Thuermann escreveu: > This patch adds the CAN raw protocol. > > Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> > Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> > > --- > include/linux/can/raw.h | 31 + > net/can/Kconfig | 11 > net

[PATCH 3/7] CAN: Add raw protocol

2007-10-02 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 821 +++

[PATCH 3/7] CAN: Add raw protocol

2007-09-25 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 822 +++

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-22 Thread Patrick McHardy
Urs Thuermann wrote: > Patrick McHardy <[EMAIL PROTECTED]> writes: >> >>>+config CAN_RAW_USER >>>+bool "Allow non-root users to access Raw CAN Protocol sockets" >> >> >>If you plan to remove this option, it should happen before merging >>since it affects userspace visible behaviour. > > > We

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-21 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > Urs Thuermann wrote: > > +config CAN_RAW_USER > > + bool "Allow non-root users to access Raw CAN Protocol sockets" > > > If you plan to remove this option, it should happen before merging > since it affects userspace visible behaviour. We have dis

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-21 Thread Patrick McHardy
Urs Thuermann wrote: > +config CAN_RAW_USER > + bool "Allow non-root users to access Raw CAN Protocol sockets" If you plan to remove this option, it should happen before merging since it affects userspace visible behaviour. - To unsubscribe from this list: send the line "unsubscribe netdev"

[PATCH 3/7] CAN: Add raw protocol

2007-09-20 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 828 ++

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-19 Thread Patrick McHardy
Urs Thuermann wrote: > Patrick McHardy <[EMAIL PROTECTED]> writes: > > >>>+config CAN_RAW_USER >>>+bool "Allow non-root users to access Raw CAN Protocol sockets" >>>+depends on CAN_RAW >> >>Would it be much more trouble for userspace to use capabilities for >>this? This would allow usersp

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-18 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > > +config CAN_RAW_USER > > + bool "Allow non-root users to access Raw CAN Protocol sockets" > > + depends on CAN_RAW > > + default N > > + ---help--- > > + The Controller Area Network is a local field bus transmitting only > > + broadca

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-18 Thread Patrick McHardy
Urs Thuermann wrote: > This patch adds the CAN raw protocol. > > Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> > Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> Also looks good, a few minor comments below. > Index: net-2.6.24/net/can/Kconfig > =

[PATCH 3/7] CAN: Add raw protocol

2007-09-17 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 767 ++

[patch 3/7] CAN: Add raw protocol

2007-08-03 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 757 ++

[patch 3/7] CAN: Add raw protocol

2007-06-21 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-Off-By: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-Off-By: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 751 ++

[patch 3/7] CAN: Add raw protocol

2007-05-30 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-Off-By: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-Off-By: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 ++ net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 703 +

[patch 3/7] CAN: Add raw protocol

2007-05-16 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-Off-By: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-Off-By: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 ++ net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 703 +