Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-22 Thread Francois Romieu
David Woodhouse : [...] > What do you think of finally enabling hw csum and TSO by default, btw? Your router can actively use it and you'll have to keep the pieces together if it breaks, right ? So I'd go for it. -- Ueimor -- To unsubscribe from this list: send the line

[PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread David Woodhouse
From: David Woodhouse When sending a TSO frame in multiple buffers, we were neglecting to set the first descriptor up in TSO mode. Signed-off-by: David Woodhouse --- drivers/net/ethernet/realtek/8139cp.c | 23 +++ 1

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread Francois Romieu
David Woodhouse : [...] > diff --git a/drivers/net/ethernet/realtek/8139cp.c > b/drivers/net/ethernet/realtek/8139cp.c > index 058f835..07621b5 100644 > --- a/drivers/net/ethernet/realtek/8139cp.c > +++ b/drivers/net/ethernet/realtek/8139cp.c [...] > @@ -865,20 +864,20 @@

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 23:01 +0200, Francois Romieu wrote: > Can you pile a patch to replace BUG with WARN_ON_ONCE(1) ? OK. I can probably contrive a userspace program using AF_PACKET and PACKET_VNET_HDR to trigger it, too¹ :) -- dwmw2 ¹ http://comments.gmane.org/gmane.linux.network/254981

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 23:01 +0200, Francois Romieu wrote: > > Can you pile a patch to replace BUG with WARN_ON_ONCE(1) ? Let's avoid having three copies of the same damn code, while we're at it... http://git.infradead.org/users/dwmw2/linux-8139cp.git has this and the appropriate minor fixes to