Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 10:45:54PM +0300, Grygorii Strashko wrote: > With this change It will not be required to add the same DT parsing code > in Keystone 2 netcp driver, so overall number of lines will be reduced. This explanation would make the commit message much more informative. Thanks,

Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Grygorii Strashko
On 09/14/2016 04:55 PM, Richard Cochran wrote: > On Wed, Sep 14, 2016 at 04:02:26PM +0300, Grygorii Strashko wrote: >> Move DT properties parsing into CPTS driver to simplify consumer's >> code and CPTS driver porting on other SoC in the future >> (like Keystone 2). > > And just who is the

Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:26PM +0300, Grygorii Strashko wrote: > Move DT properties parsing into CPTS driver to simplify consumer's > code and CPTS driver porting on other SoC in the future > (like Keystone 2). And just who is the consumer? > Signed-off-by: Grygorii Strashko

[PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify consumer's code and CPTS driver porting on other SoC in the future (like Keystone 2). Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 16 +--- drivers/net/ethernet/ti/cpsw.h | 2