On Mon, 2007-15-10 at 18:55 +0400, Alexey Kuznetsov wrote:
> Hello!
Didnt mean to wake you up Alexey ;->
> I see not so many places inside net/sched/act* where skb_clone is used.
> Exactly one in act_mirred.c, to be more exact. Did I miss something?
No you are right, thats the only spot at the m
Hello!
> If it is causing trouble, then one idea would be to move the resetting
> to a wrapper function which calls clone first and then resets the other
> fields. All actions currently cloning would need to be mod-ed to use
> that call.
I see not so many places inside net/sched/act* where skb_cl
jamal wrote:
Also, iirc this started as a netfilter optimization thing starting with
tail-calls - can someone (Patrick?) clue me how it helps in that
optimization aspect?
Most NF_HOOK invocations look like this:
return NF_HOOK();
NF_HOOK does (did):
({int __ret; \
if ((__ret=nf_hook_th
On Sun, 2007-14-10 at 06:49 -0400, jamal wrote:
> Once this patchset makes
> it into net-2.6.24 i can do testing on my laptop and provide you any
> further feedback.
Works on all 4 tests i tried out on net-2.6[1]. GoodStuff Herbert.
Herbert, please look at the comment i sent on the clone vs copy
On Sun, 2007-14-10 at 12:27 +0800, Herbert Xu wrote:
> [NET]: Avoid unnecessary cloning for ingress filtering
>
> As it is we always invoke pt_prev before ing_filter, even if there are no
> ingress filters attached. This can cause unnecessary cloning in pt_prev.
>
> This patch changes it so that
[NET]: Avoid unnecessary cloning for ingress filtering
As it is we always invoke pt_prev before ing_filter, even if there are no
ingress filters attached. This can cause unnecessary cloning in pt_prev.
This patch changes it so that we only invoke pt_prev if there are ingress
filters attached.
S
