Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-16 Thread Ingo Oeser
Shaun Pereira wrote: removed magic number 33 as suggested by Arnaldo But are you sure, you use the right substitute for it? struct x25_calluserdata { diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/include/net/x25.h linux-2.6.16-rc3/include/net/x25.h ---

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-16 Thread Shaun Pereira
Thank for reviewing the patch Ingo. There was a mistake the first time round, lucky for me Arnaldo's comment about the magic number helped me spot it. When ITU-T DTE facilities are added to the X.25 header packet the length field has to contain n + 1 bytes where n is the number of bytes needed to

[PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-15 Thread Shaun Pereira
This patch is a re-submit of an earlier patch submitted by Andrew Hendry that did not make it into the Linux Kernel. Here is some more information about this patch. Hope this is helpful. This patch allows use of the optional user facility to insert ITU-T (http://www.itu.int/ITU-T/) specified DTE

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-15 Thread Arnaldo Carvalho de Melo
On 2/15/06, Shaun Pereira [EMAIL PROTECTED] wrote: + switch (*p) { + case X25_FAC_CALLING_AE: + if (p[1] 33) + break; + dte_facs-calling_len = p[2]; +

[PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-15 Thread Shaun Pereira
32 bit modular socket ioctl emulation for 64 bit kernel This patch is a re-submit of an earlier patch submitted by Andrew Hendry that did not make it into the Linux Kernel. Here is some more information about this patch. This patch allows use of the optional user facility to insert ITU-T

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-15 Thread Shaun Pereira
Thanks for that Aranaldo I have corrected this so as to be compliant with OSI Network services for DTE facilities and rebuilt and retested the patches Corrected patches follow. On Wed, 2006-02-15 at 20:35 -0200, Arnaldo Carvalho de Melo wrote: On 2/15/06, Shaun Pereira [EMAIL PROTECTED]

[PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-15 Thread Shaun Pereira
removed magic number 33 as suggested by Arnaldo 32 bit modular socket ioctl emulation for 64 bit kernel This patch is a re-submit of an earlier patch submitted by Andrew Hendry that did not make it into the Linux Kernel. Here is some more information about this patch. This patch allows use