Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-29 Thread Cong Wang
On Wed, Jan 27, 2016 at 1:05 PM, Eric Dumazet wrote: > On Wed, 2016-01-27 at 11:50 -0800, Cong Wang wrote: > >> Hmm? I think nfc_llcp_send_ui_frame() needs to do some fragmention >> with this temporary memory, or you are saying msg_iter has some >> API available to seek the pointer? Even if so, it

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-27 Thread Eric Dumazet
On Wed, 2016-01-27 at 11:50 -0800, Cong Wang wrote: > Hmm? I think nfc_llcp_send_ui_frame() needs to do some fragmention > with this temporary memory, or you are saying msg_iter has some > API available to seek the pointer? Even if so, it doesn't look like > suitable for -stable. > memcpy_from_m

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-27 Thread Cong Wang
On Tue, Jan 26, 2016 at 6:23 PM, Eric Dumazet wrote: > On Tue, 2016-01-26 at 15:12 -0800, Cong Wang wrote: >> On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby >> wrote: >> > Hi Cong, >> > >> > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang >> > wrote: >> > >> > A commit message would be nice. A brie

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-26 Thread Eric Dumazet
On Tue, 2016-01-26 at 15:12 -0800, Cong Wang wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby > wrote: > > Hi Cong, > > > > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: > > > > A commit message would be nice. A brief rundown of how this is called > > from userspace would be nice (I'm

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-26 Thread Julian Calaby
Hi Cong, On Wed, Jan 27, 2016 at 10:12 AM, Cong Wang wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby > wrote: >> Hi Cong, >> >> On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: >> >> A commit message would be nice. A brief rundown of how this is called >> from userspace would be nice

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-26 Thread Cong Wang
On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby wrote: > Hi Cong, > > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: > > A commit message would be nice. A brief rundown of how this is called > from userspace would be nice (I'm talking a single sentence here, e.g. > "this is allocated when submi

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-26 Thread Julian Calaby
Hi Cong, On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: A commit message would be nice. A brief rundown of how this is called from userspace would be nice (I'm talking a single sentence here, e.g. "this is allocated when submitting a nfc packet") and what issue __GFP_NOWARN is fixing. (I'm gu

[PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-26 Thread Cong Wang
Reported-by: Dmitry Vyukov Cc: Lauro Ramos Venancio Cc: Aloisio Almeida Jr Cc: Samuel Ortiz Signed-off-by: Cong Wang --- net/nfc/llcp_commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c index 3621a90..5d94055 100644