Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-26 Thread Jiri Pirko
Sun, Mar 25, 2018 at 04:24:11PM CEST, d...@cumulusnetworks.com wrote: >On 3/24/18 10:02 AM, Jiri Pirko wrote: Wait a second. What do you mean by "per-network namespace"? Devlink instance is always associated with one physical device. Like an ASIC. >>

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-25 Thread Jakub Kicinski
On Sun, 25 Mar 2018 08:27:42 -0600, David Ahern wrote: > On 3/25/18 12:35 AM, Jakub Kicinski wrote: > > On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: > diff --git a/drivers/net/netdevsim/Makefile > b/drivers/net/netdevsim/Makefile > index 09388c06171d..449b2a1a1800 100644

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-25 Thread David Ahern
On 3/25/18 12:35 AM, Jakub Kicinski wrote: > On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: diff --git a/drivers/net/netdevsim/Makefile b/drivers/net/netdevsim/Makefile index 09388c06171d..449b2a1a1800 100644 --- a/drivers/net/netdevsim/Makefile +++ b/drivers/net/n

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-25 Thread David Ahern
On 3/24/18 10:02 AM, Jiri Pirko wrote: >>> >>> Wait a second. What do you mean by "per-network namespace"? Devlink >>> instance is always associated with one physical device. Like an ASIC. >>> >>> has a net entry, the simplest design is to put it into the namespace of >

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-24 Thread Jakub Kicinski
On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: > >> diff --git a/drivers/net/netdevsim/Makefile > >> b/drivers/net/netdevsim/Makefile > >> index 09388c06171d..449b2a1a1800 100644 > >> --- a/drivers/net/netdevsim/Makefile > >> +++ b/drivers/net/netdevsim/Makefile > >> @@ -9,3 +9,7 @@ ifeq (

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-24 Thread Jiri Pirko
Sat, Mar 24, 2018 at 04:05:38PM CET, d...@cumulusnetworks.com wrote: >On 3/24/18 1:26 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 04:13:14PM CET, d...@cumulusnetworks.com wrote: >>> On 3/23/18 9:05 AM, Jiri Pirko wrote: Fri, Mar 23, 2018 at 04:03:40PM CET, d...@cumulusnetworks.com wrote: >>>

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-24 Thread David Ahern
On 3/24/18 1:26 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 04:13:14PM CET, d...@cumulusnetworks.com wrote: >> On 3/23/18 9:05 AM, Jiri Pirko wrote: >>> Fri, Mar 23, 2018 at 04:03:40PM CET, d...@cumulusnetworks.com wrote: On 3/23/18 9:01 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 03:31:

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-24 Thread David Ahern
On 3/23/18 9:47 PM, Jakub Kicinski wrote: > On Thu, 22 Mar 2018 15:57:57 -0700, David Ahern wrote: >> From: David Ahern >> >> Add devlink support to netdevsim and use it to implement a simple, >> profile based resource controller. Only one controller is needed >> per namespace, so the first netdev

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-24 Thread Jiri Pirko
Fri, Mar 23, 2018 at 04:13:14PM CET, d...@cumulusnetworks.com wrote: >On 3/23/18 9:05 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 04:03:40PM CET, d...@cumulusnetworks.com wrote: >>> On 3/23/18 9:01 AM, Jiri Pirko wrote: Fri, Mar 23, 2018 at 03:31:02PM CET, d...@cumulusnetworks.com wrote: >>>

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread Jakub Kicinski
On Thu, 22 Mar 2018 15:57:57 -0700, David Ahern wrote: > From: David Ahern > > Add devlink support to netdevsim and use it to implement a simple, > profile based resource controller. Only one controller is needed > per namespace, so the first netdevsim netdevice in a namespace > registers with de

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread David Ahern
On 3/23/18 9:05 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 04:03:40PM CET, d...@cumulusnetworks.com wrote: >> On 3/23/18 9:01 AM, Jiri Pirko wrote: >>> Fri, Mar 23, 2018 at 03:31:02PM CET, d...@cumulusnetworks.com wrote: On 3/23/18 12:50 AM, Jiri Pirko wrote: >> +void nsim_devlink_setup(

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread Jiri Pirko
Fri, Mar 23, 2018 at 04:03:40PM CET, d...@cumulusnetworks.com wrote: >On 3/23/18 9:01 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 03:31:02PM CET, d...@cumulusnetworks.com wrote: >>> On 3/23/18 12:50 AM, Jiri Pirko wrote: > +void nsim_devlink_setup(struct netdevsim *ns) > +{ > + struct

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread David Ahern
On 3/23/18 9:01 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 03:31:02PM CET, d...@cumulusnetworks.com wrote: >> On 3/23/18 12:50 AM, Jiri Pirko wrote: +void nsim_devlink_setup(struct netdevsim *ns) +{ + struct net *net = dev_net(ns->netdev); + bool *reg_devlink = net_generic(n

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread Jiri Pirko
Fri, Mar 23, 2018 at 03:31:02PM CET, d...@cumulusnetworks.com wrote: >On 3/23/18 12:50 AM, Jiri Pirko wrote: >>> +void nsim_devlink_setup(struct netdevsim *ns) >>> +{ >>> + struct net *net = dev_net(ns->netdev); >>> + bool *reg_devlink = net_generic(net, nsim_devlink_id); >>> + struct devlink

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-23 Thread David Ahern
On 3/23/18 12:50 AM, Jiri Pirko wrote: >> +void nsim_devlink_setup(struct netdevsim *ns) >> +{ >> +struct net *net = dev_net(ns->netdev); >> +bool *reg_devlink = net_generic(net, nsim_devlink_id); >> +struct devlink *devlink; >> +int err = -ENOMEM; >> + >> +/* only one device pe

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-22 Thread Jiri Pirko
Thu, Mar 22, 2018 at 11:57:57PM CET, d...@cumulusnetworks.com wrote: >From: David Ahern [...] >+void nsim_devlink_teardown(struct netdevsim *ns) >+{ >+ if (ns->devlink) { >+ struct net *net = dev_net(ns->netdev); >+ bool *reg_devlink = net_generic(net, nsim_devlin

[PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

2018-03-22 Thread David Ahern
From: David Ahern Add devlink support to netdevsim and use it to implement a simple, profile based resource controller. Only one controller is needed per namespace, so the first netdevsim netdevice in a namespace registers with devlink. If that device is deleted, the resource settings are deleted