Re: [PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Alexei Starovoitov
On Fri, Oct 26, 2018 at 10:57:18PM +, Roman Gushchin wrote: > On Sat, Oct 27, 2018 at 12:49:02AM +0200, Daniel Borkmann wrote: > > Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() > > helper function") enabled the bpf_get_local_storage() helper also > > for BPF program types whe

Re: [PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Roman Gushchin
On Sat, Oct 27, 2018 at 12:49:02AM +0200, Daniel Borkmann wrote: > Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() > helper function") enabled the bpf_get_local_storage() helper also > for BPF program types where it does not make sense to use them. > > They have been added both in

[PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Daniel Borkmann
Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() helper function") enabled the bpf_get_local_storage() helper also for BPF program types where it does not make sense to use them. They have been added both in sk_skb_func_proto() and sk_msg_func_proto() even though both program types