Re: [PATCH bpf 1/2] tools: bpftool: remove duplicated error message on prog load

2018-06-20 Thread Song Liu
On Wed, Jun 20, 2018 at 11:42 AM, Jakub Kicinski wrote: > do_pin_fd() will already print out an error message if something > goes wrong. Printing another error is unnecessary and will break > JSON output, since error messages are full objects: > > $ bpftool -jp prog load tracex1_kern.o

[PATCH bpf 1/2] tools: bpftool: remove duplicated error message on prog load

2018-06-20 Thread Jakub Kicinski
do_pin_fd() will already print out an error message if something goes wrong. Printing another error is unnecessary and will break JSON output, since error messages are full objects: $ bpftool -jp prog load tracex1_kern.o /sys/fs/bpf/a { "error": "can't pin the object (/sys/fs/bpf/a): File