Re: [PATCH bpf 1/4] xsk: fix potential lost completion message in SKB path

2018-06-28 Thread Song Liu
On Wed, Jun 27, 2018 at 7:02 AM, Magnus Karlsson wrote: > The code in xskq_produce_addr erroneously checked if there > was up to LAZY_UPDATE_THRESHOLD amount of space in the completion > queue. It only needs to check if there is one slot left in the > queue. This bug could under some

[PATCH bpf 1/4] xsk: fix potential lost completion message in SKB path

2018-06-27 Thread Magnus Karlsson
The code in xskq_produce_addr erroneously checked if there was up to LAZY_UPDATE_THRESHOLD amount of space in the completion queue. It only needs to check if there is one slot left in the queue. This bug could under some circumstances lead to a WARN_ON_ONCE being triggered and the completion