Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-06 Thread Or Gerlitz
On Fri, Mar 4, 2016 at 4:35 PM, Doug Ledford wrote: [...] > So, at *best*, the solution you are suggesting for existing setups is a > partial solution that leaves things only half done. [...] Doug, Point/s taken, justifying the code re-route of libvirt attempting to issue

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-04 Thread Doug Ledford
On 03/02/2016 01:40 PM, Or Gerlitz wrote: > On Wed, Mar 2, 2016 at 6:50 PM, Doug Ledford wrote: > >> Exactly *what* provisioning system tries to set the VF_MAC on an IPoIB >> interface and expects it to set the GUID of an underlying IB device? > > The provisioning system

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-02 Thread Or Gerlitz
On Wed, Mar 2, 2016 at 6:50 PM, Doug Ledford wrote: > Exactly *what* provisioning system tries to set the VF_MAC on an IPoIB > interface and expects it to set the GUID of an underlying IB device? The provisioning system need not be fully aware in all their components this

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-02 Thread Doug Ledford
On 3/1/2016 4:08 PM, Or Gerlitz wrote: > On Tue, Mar 1, 2016 at 8:25 PM, Jason Gunthorpe > wrote: >> On Tue, Mar 01, 2016 at 07:49:51PM +0200, Eli Cohen wrote: >>> On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: > + return

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Or Gerlitz
On Tue, Mar 1, 2016 at 8:25 PM, Jason Gunthorpe wrote: > On Tue, Mar 01, 2016 at 07:49:51PM +0200, Eli Cohen wrote: >> On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: >> > > + return handle_infiniband_guid(dev, , IFLA_VF_IB_PORT_GUID); >> > >> >

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Jason Gunthorpe
On Tue, Mar 01, 2016 at 07:49:51PM +0200, Eli Cohen wrote: > On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: > > > + return handle_infiniband_guid(dev, , IFLA_VF_IB_PORT_GUID); > > > > But is this emulation really necessary? It seems dangerous and > > continues the bad practice

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Eli Cohen
On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: > > + return handle_infiniband_guid(dev, , IFLA_VF_IB_PORT_GUID); > > But is this emulation really necessary? It seems dangerous and > continues the bad practice of assuming IFLA_VF_MAC is fixed to 6 bytes > in size, and is not

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Jason Gunthorpe
On Tue, Mar 01, 2016 at 06:52:14PM +0200, Eli Cohen wrote: > Add two new NLAs to support configuration of Infiniband node or port > GUIDs. New applications can choose to use this interface to configure > GUIDs with iproute2 with commands such as: > > ip link set dev ib0 vf 0 node_guid

[PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Eli Cohen
Add two new NLAs to support configuration of Infiniband node or port GUIDs. New applications can choose to use this interface to configure GUIDs with iproute2 with commands such as: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set dev ib0 vf 0 port_guid