Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-01-18 Thread Doug Ledford
On Wed, 2017-01-18 at 14:42 +0530, Selvin Xavier wrote: > On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky > wrote: > > > > It is better to use already existing macros - min() > > cq->max_cql = min(entries, MAX_CQL_PER_POLL); > > > > I afraid that you can't avoid the respinning, you have more th

Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-01-18 Thread Selvin Xavier
On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky wrote: > It is better to use already existing macros - min() > cq->max_cql = min(entries, MAX_CQL_PER_POLL); > > I afraid that you can't avoid the respinning, you have more than month > till merge window. > > Can you please remove useless wrappers a

Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-01-18 Thread Leon Romanovsky
On Wed, Dec 21, 2016 at 03:41:59AM -0800, Selvin Xavier wrote: > Implements support for create_cq, destroy_cq and req_notify_cq > verbs. > > v3: Code cleanup based on errors reported by sparse on endianness check. > Removes unwanted macros. > > Signed-off-by: Eddie Wai > Signed-off-by: Devesh

[PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2016-12-21 Thread Selvin Xavier
Implements support for create_cq, destroy_cq and req_notify_cq verbs. v3: Code cleanup based on errors reported by sparse on endianness check. Removes unwanted macros. Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna S