Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 27 Mar 2018 19:33:28 +0200 Alexander Zubkov wrote: > master before merging revert + my recent patch (1) should work. Or you mean > to prepare patch to change new master to desired state? I can do it. > > 1) >

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

master before merging revert + my recent patch (1) should work. Or you mean to prepare patch to change new master to desired state? I can do it. 1) https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/patch/?id=7696f1097f79be2ce5984a8a16103fd17391cac2 27.03.2018, 19:00, "Stephen

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hi Stephen, Looks like the new patch was applied after the revert of original patch and fix patch for 4.15 branch. Which is not correct and I did not test it. This is how patches were designed: 1) your revert patch - rolls back 4.15 branch to old behaviour by reverting the original patch 2) my

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 27 Mar 2018 18:29:31 +0200 Alexander Zubkov wrote: > Hi Stephen, > > Looks like the new patch was applied after the revert of original patch and > fix patch for 4.15 branch. Which is not correct and I did not test it. This > is how patches were designed: > 1) your revert

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Wed, 14 Mar 2018 21:26:40 +0100 Alexander Zubkov wrote: > Hello, > > For example, it can be fixed in such way (patch is below): > - split handling of default and all/any > - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default > - and AF_UNSPEC for all/any >

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello, For example, it can be fixed in such way (patch is below): - split handling of default and all/any - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default - and AF_UNSPEC for all/any In this case "ip route show default" shows only default route and "ip route show all"

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello, There was a series of patches by Serhey and specifically this one: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=93fa12418dc6f5943692250244be303bb162175b It drops handling of special prefix names in get_prefix_1(), and in get_addr_1() they always receive family

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hi, I just realized that you need patch for v4.15.0, which is easier to do. I'll send it as separate message now. I will make patch for the master branch, but later. On 13.03.2018 13:02, Luca Boccassi wrote: On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: Hello again, The fun

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 2018-03-13 at 21:12 +0100, Alexander Zubkov wrote: > Hi, > > I just realized that you need patch for v4.15.0, which is easier to > do. > I'll send it as separate message now. I will make patch for the > master  > branch, but later. Thanks but don't worry about 4.15 - Stephen's revert

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: > Hello again, > > The fun thing is that before the commit "ip route ls all" showed all > routes, but "ip -[4|6] route ls all" showed only default. So it was > broken too, but in other way. > I see parsing of prefix was changed since my

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello again, The fun thing is that before the commit "ip route ls all" showed all routes, but "ip -[4|6] route ls all" showed only default. So it was broken too, but in other way. I see parsing of prefix was changed since my patch. So I need several days to propose fix. I think if "ip route ls

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello. May be the better way would be to change how "all"/"any" argument behaves? My original concern was about "default" only. I agree too, that "all" or "any" should work for all routes. But not for the default. 12.03.2018, 22:37, "Luca Boccassi" : > On Mon, 2018-03-12 at

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: > This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. > > Debian maintainer found that basic command: > # ip route flush all > No longer worked as expected which breaks user scripts and > expectations. It no longer

[PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. Debian maintainer found that basic command: # ip route flush all No longer worked as expected which breaks user scripts and expectations. It no longer flushed all IPv4 routes. Reported-by: Luca Boccassi