addattr16 may return an error about the nl msg size
but not about incorrect eth type.
Fixes: 488b41d020fb ("tc: flower no need to specify the ethertype")
Signed-off-by: Roi Dayan <r...@mellanox.com>
Reviewed-by: Paul Blakey <pa...@mellanox.com>
---
tc/f_flower.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 1272a47..314c2dd 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -530,11 +530,8 @@ parse_done:
return ret;
ret = addattr16(n, MAX_MSG, TCA_FLOWER_KEY_ETH_TYPE, eth_type);
- if (ret) {
- fprintf(stderr, "Illegal \"eth_type\"(0x%x)\n",
- ntohs(eth_type));
- return -1;
- }
+ if (ret)
+ return ret;
tail->rta_len = (((void *)n)+n->nlmsg_len) - (void *)tail;
--
1.7.1
