Re: [PATCH ipsec-next] xfrm: policy: fix netlink/pf_key policy lookups

2018-11-19 Thread Steffen Klassert
On Thu, Nov 15, 2018 at 02:51:57AM +0100, Florian Westphal wrote: > Colin Ian King says: > Static analysis with CoverityScan found a potential issue [..] > It seems that pointer pol is set to NULL and then a check to see if it > is non-null is used to set pol to tmp; howeverm this check is

[PATCH ipsec-next] xfrm: policy: fix netlink/pf_key policy lookups

2018-11-14 Thread Florian Westphal
Colin Ian King says: Static analysis with CoverityScan found a potential issue [..] It seems that pointer pol is set to NULL and then a check to see if it is non-null is used to set pol to tmp; howeverm this check is always going to be false because pol is always NULL. Fix this and update