Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-06 Thread Or Gerlitz
On Thu, Sep 6, 2018 at 7:09 AM, Leon Romanovsky wrote: > On Thu, Sep 06, 2018 at 12:37:17AM +0300, Or Gerlitz wrote: >> On Wed, Sep 5, 2018 at 9:11 PM, Leon Romanovsky wrote: >> > On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote: >> >> On Wed, Sep 05, 2018 at 08:10:25AM +0300,

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-05 Thread Leon Romanovsky
On Thu, Sep 06, 2018 at 12:37:17AM +0300, Or Gerlitz wrote: > On Wed, Sep 5, 2018 at 9:11 PM, Leon Romanovsky wrote: > > On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote: > >> On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon Romanovsky wrote: > >> > > > - int en_encap_decap =

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-05 Thread Or Gerlitz
On Wed, Sep 5, 2018 at 9:11 PM, Leon Romanovsky wrote: > On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote: >> On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon Romanovsky wrote: >> > > > - int en_encap_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN); >> > > > + int en_encap

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-05 Thread Leon Romanovsky
On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote: > On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon Romanovsky wrote: > > > > - int en_encap_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN); > > > > + int en_encap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN_ENCAP); > > > > +

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-05 Thread Jason Gunthorpe
On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon Romanovsky wrote: > > > - int en_encap_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN); > > > + int en_encap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN_ENCAP); > > > + int en_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN_DECAP); > > > > Yuk, please don't use

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-04 Thread Leon Romanovsky
On Tue, Sep 04, 2018 at 04:02:42PM -0600, Jason Gunthorpe wrote: > On Tue, Aug 28, 2018 at 02:18:44PM +0300, Leon Romanovsky wrote: > > From: Mark Bloch > > > > Today we are able to attach encap and decap actions only to the FDB. In > > preparation to enable those actions on the NIC flow tables,

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-04 Thread Jason Gunthorpe
On Tue, Aug 28, 2018 at 02:18:44PM +0300, Leon Romanovsky wrote: > From: Mark Bloch > > Today we are able to attach encap and decap actions only to the FDB. In > preparation to enable those actions on the NIC flow tables, break the > single flag into two. Those flags control whatever a decap or

[PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-08-28 Thread Leon Romanovsky
From: Mark Bloch Today we are able to attach encap and decap actions only to the FDB. In preparation to enable those actions on the NIC flow tables, break the single flag into two. Those flags control whatever a decap or encap operations can be attached to the flow table created. For FDB, if