Re: [PATCH net] 8139too: revisit napi_complete_done() usage

2018-01-22 Thread Eric Dumazet
On Mon, 2018-01-22 at 12:27 -0500, tedheadster wrote: > On Mon, Sep 18, 2017 at 11:57 PM, David Miller wrote: > > From: Eric Dumazet > > Date: Mon, 18 Sep 2017 13:03:43 -0700 > > > > > From: Eric Dumazet > > > > > > It seems we have to be more careful in napi_complete_done() > > > use. This pa

Re: [PATCH net] 8139too: revisit napi_complete_done() usage

2018-01-22 Thread tedheadster
On Mon, Sep 18, 2017 at 11:57 PM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 18 Sep 2017 13:03:43 -0700 > >> From: Eric Dumazet >> >> It seems we have to be more careful in napi_complete_done() >> use. This patch is not a revert, as it seems we can >> avoid bug that Ville reported by

Re: [PATCH net] 8139too: revisit napi_complete_done() usage

2017-09-18 Thread David Miller
From: Eric Dumazet Date: Mon, 18 Sep 2017 13:03:43 -0700 > From: Eric Dumazet > > It seems we have to be more careful in napi_complete_done() > use. This patch is not a revert, as it seems we can > avoid bug that Ville reported by moving the napi_complete_done() > test in the spinlock section.

[PATCH net] 8139too: revisit napi_complete_done() usage

2017-09-18 Thread Eric Dumazet
From: Eric Dumazet It seems we have to be more careful in napi_complete_done() use. This patch is not a revert, as it seems we can avoid bug that Ville reported by moving the napi_complete_done() test in the spinlock section. Many thanks to Ville for detective work and all tests. Fixes: 617f012