Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

I did the temporary clearing/restoring rt_gateway following the deleted function check_peer_redir(). But, looking again at the function the assigning of peer->redirect_learned.a4 to rt_gateway can be permanent because restoring to the old_gw only happens on errors. I have updated the patch to use

Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

From: Eric Dumazet Date: Mon, 07 Nov 2016 08:08:52 -0800 > In any case, rt is a shared object at that time, so even temporarily > clearing/restoring rt_gateway seems wrong to me. > > I would rather call __ipv4_neigh_lookup(dst->dev, new_gw) directly at > this point.

Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

On Mon, 2016-11-07 at 10:04 -0500, Stephen Suryaputra Lin wrote: > ICMP redirects behavior is different after the commit above. An email > requesting the explanation on why the behavior needs to be different > was sent earlier to netdev (https://patchwork.ozlabs.org/patch/687728/). > Since there

[PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

ICMP redirects behavior is different after the commit above. An email requesting the explanation on why the behavior needs to be different was sent earlier to netdev (https://patchwork.ozlabs.org/patch/687728/). Since there isn't a reply yet, I decided to prepare this formal patch. In v2.6